Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow continuation of a reindex #2067

Merged
merged 1 commit into from Feb 8, 2024
Merged

Conversation

whikloj
Copy link
Collaborator

@whikloj whikloj commented Dec 1, 2023

JIRA Ticket: https://fedora-repository.atlassian.net/jira/software/c/projects/FCREPO/issues/FCREPO-3907

What does this Pull Request do?

Adds a new flag to allow the continuation of a failed re-indexing.

How should this be tested?

In theory you need a lot of objects.

  1. Start up the site either with empty indexes to with fcrepo.rebuild.on.start=true set.
  2. Stop or wait for it to fail (assuming it does normally fail)
  3. Set fcrepo.rebuild.continue=true, you can remove the fcrepo.rebuild.on.start flag but this flag takes precendence so you will still be okay.
  4. Start Fedora.

The messages will now show a count of those skipped items as well as successful and errors. At the end you should have all your items available.

Interested parties

Tag (@ mention) interested parties or, if unsure, @fcrepo/committers

Copy link
Contributor

@mikejritter mikejritter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built and tested this to confirm that it works. I ended up removing some of the rows from the index and then used the flag to trigger the rebuild.

Everything else looks good, just one question that I don't think will be an issue but figured I'd ask about.

@mikejritter mikejritter merged commit 63ffc1b into fcrepo:main Feb 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants