Add a SMT for OCFL path #2079
Open
Add a SMT for OCFL path #2079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket: https://fedora-repository.atlassian.net/browse/FCREPO-3935
What does this Pull Request do?
Generates a Server Managed Triple
fedora:ocflPathwith the full path to the base of the resource.How should this be tested?
This is a bit hacky as the only way to know if something is in staging or the repo is to get that information from
fcrepo-storage-ocfland pass it back as part of the Resource Headers (I think).That seemed like a large change, which I think involves to change the resource headers object (in fcrepo-storage-ocfl) to store the path and change the conversion code from OCFL resource headers to Fedora resource headers to set this path. Then change the ResourceFactory to transfer the path from the resource headers to the FedoraResource. Then we could still use the ManagedPropertiesService to set the triple using the path.
This makes some assumptions, which if we ever make the path configurable would make it invalid. 馃し
To test, build and run this code. Make an object in Fedora, view the metadata for that object and find a new
http://fedora.info/definitions/v4/repository#ocflPathtriple with the full path on disk.For Archival Groups and their parts, they all point to the path of the Archival Group.
Interested parties
Tag (@ mention) interested parties or, if unsure, @fcrepo/committers