Bring derby's PATCH in line with fcrepo4's. #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome. Agreed that this issue is fundamentally an rdf/rdf-ldp layer concern. The place to patch is: https://github.com/ruby-rdf/rdf-ldp/blob/develop/lib/rdf/ldp/rdf_source.rb#L168-L185 Is the |
|
Closing this out and submitting a PR to rdf/rdf-ldp. You were dead on about using the SPARQL gem to manipulate the input. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fcrepo4 accepts
sparql-updatepatches with<>subjects as placeholders for the URI of the request. It also returns204 No Contenton a successful patch instead of200 OK. This pull request does both of those things from the derby side, because I was unsure whether this behavior should be part of LDP or whether it's specific to the Fedora implementation.