-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fcrepo 1555 #810
Closed
Closed
Fcrepo 1555 #810
Changes from 5 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
0bbe914
Replace fedora:Blanknode with fedora:Skolem in the code and in the on…
yinlinchen 54ca813
swap out guava Optional for java8 Optional
acoburn e7bac73
remove guava splitter
acoburn 2e8d537
removed guava Function
acoburn e05bbd5
remove guava Iterables for a java8 stream
acoburn bb4eee5
replace guava iterables with java8 streams
acoburn 8734270
replace guava nullOrEmpty with Optional
acoburn 8c5d397
replace guava transform with java8 stream map
acoburn a54ddff
replaced guava Predicate with java8 stream
acoburn c2ab828
remove guava Predicate in favor of java8 Stream API
acoburn 78be702
removed RdfSerializationUtils class
acoburn 6814fb7
modifications to improve the error msg for a GET-PUT-PUT operation (4…
aa47128
update PR after feedback from ajs6f
acoburn 454a57f
import Collectors.toList statically
acoburn 4f35aca
restore ternary operator
acoburn 8b05d1b
REST GET-PUT-PUT operations should return a 409 error and an improved…
3ca6749
removed the logger imports used in testing
8f0b9dd
Thought i'd broken the project, but I hadn't. Minimal changes I think…
3c81f10
Code modifications based upon code review of http://github.com/fcrepo…
25f62f1
Merge pull request #809 from acoburn/fcrepo-1563
ajs6f e6b0305
Merge pull request #805 from yinlinchen/fcrepo-1394
ajs6f 1a96fe7
Suggestion for not wrapping ServerManagedPropertyExceptions
7591601
FedoraEvent now mints internal UUID for downstream use
escowles 17aa1d2
Using awoods work on non-wrapping ServerManagedPropertyExceptions, ma…
3d11cdb
Merge branch 'fcrepo-1555' of github.com:robyj/fcrepo4 into fcrepo-1555
7994f54
Merge pull request #1 from awoods/fcrepo-1555
robyj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -322,10 +322,11 @@ public void removeProperty(final FedoraResource resource, | |
|
||
if (isManagedPredicate.apply(predicate)) { | ||
|
||
throw new ServerManagedPropertyException("Could not remove triple containing predicate " | ||
+ predicate.toString() | ||
+ " to node " | ||
+ node.getPath()); | ||
throw new ServerManagedPropertyException("Could not remove triple containing server-managed " | ||
+ "predicate " | ||
+ predicate.toString() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unnecessary |
||
+ " to node " | ||
+ node.getPath()); | ||
} | ||
|
||
if (objectNode.isURIResource() | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessarily in this PR, but sometime, we should factor this string out into a constant in the appropriate class.