fix PEP8 issues

fcurella · May 31, 2016 · ea34034 · ea34034
1 parent b13347b
commit ea34034
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 13 deletions.
diff --git a/recommends/tasks.py b/recommends/tasks.py
@@ -1,13 +1,17 @@
+from django.apps import apps
+
 from celery.task import task, periodic_task
 from celery.schedules import crontab
+
+from recommends.providers import recommendation_registry
+
 from .utils import filelock
 
 from .settings import RECOMMENDS_TASK_RUN, RECOMMENDS_TASK_CRONTAB, RECOMMENDS_TASK_EXPIRES
 
 
 def recommends_precompute():
     results = []
-    from .providers import recommendation_registry
 
     # I know this is weird, but it's faster (tested on CPyhton 2.6.5)
     def _precompute(provider_instance):
@@ -22,8 +26,10 @@ def _precompute(provider_instance):
                 recommendation_registry.storage.release_lock()
     else:
         with filelock('recommends_precompute.lock'):
-            [_precompute(provider_instance)
-             for provider_instance in recommendation_registry.get_vote_providers()]
+            [
+                _precompute(provider_instance)
+                for provider_instance in recommendation_registry.get_vote_providers()
+            ]
 
     return results
 
@@ -35,9 +41,6 @@ def _recommends_precompute():
 
 @task(name='remove_suggestions')
 def remove_suggestions(rated_model, object_id):
-    from django.apps import apps
-    from recommends.providers import recommendation_registry
-
     ObjectClass = apps.get_model(*rated_model.split('.'))
     provider_instance = recommendation_registry.get_provider_for_content(
         ObjectClass)
@@ -48,9 +51,6 @@ def remove_suggestions(rated_model, object_id):
 
 @task(name='remove_similarities')
 def remove_similarities(rated_model, object_id):
-    from django.apps import apps
-    from recommends.providers import recommendation_registry
-
     ObjectClass = apps.get_model(*rated_model.split('.'))
     provider_instance = recommendation_registry.get_provider_for_content(
         ObjectClass)

diff --git a/recommends/tests/runtests.py b/recommends/tests/runtests.py
@@ -2,6 +2,9 @@
 import sys
 from os import path
 
+import django
+from django.test.utils import get_runner
+
 from django.conf import settings
 
 PROJECT_DIR = path.dirname(path.realpath(__file__))
@@ -24,7 +27,7 @@
     TEMPLATE_DIRS=(
         path.join(PROJECT_DIR, 'templates'),
     ),
-    MIDDLEWARE_CLASSES = (
+    MIDDLEWARE_CLASSES=(
         'django.contrib.sessions.middleware.SessionMiddleware',
         'django.middleware.common.CommonMiddleware',
         'django.middleware.csrf.CsrfViewMiddleware',
@@ -44,13 +47,11 @@
 
 
 def runtests(*test_args):
-    import django
     try:
         django.setup()  # Django 1.7+
     except AttributeError:
         pass
-    import django.test.utils
-    runner_class = django.test.utils.get_runner(settings)
+    runner_class = get_runner(settings)
     test_runner = runner_class(verbosity=1, interactive=True)
     failures = test_runner.run_tests(['recommends'])
     sys.exit(failures)