Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: escape attribute selectors #651

Closed
wants to merge 2 commits into from
Closed

feat: escape attribute selectors #651

wants to merge 2 commits into from

Conversation

danschalow
Copy link

What was changed?

  • Replaces single escape rule for colon : -> \\: with CSS.escape
  • adds unit test for escaping semi colon ; -> \\;

@danschalow danschalow mentioned this pull request Mar 15, 2024
Closed
@fczbkk fczbkk self-assigned this Mar 15, 2024
@fczbkk
Copy link
Owner

fczbkk commented Mar 15, 2024

Closing, used different solution:
52d159e

See the comments in #650 for more details.

@fczbkk fczbkk closed this Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fczbkk fczbkk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danschalow @fczbkk