Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop sealed requirement on KafkaProducerConnection #1202

Open
wants to merge 2 commits into
base: series/3.x
Choose a base branch
from

Conversation

calvinlfer
Copy link

@calvinlfer calvinlfer commented May 25, 2023

Hey there,

I'd like to propose dropping the sealed requirement on the KafkaProducerConnection in order to support the use case of being able to extend and proxy the underlying KafkaProducerConnection in order to trace methods (for distributed tracing) so libraries like Trace4Cats can trace methods on the KafkaProducerConnection in a similar way to how tracing is done on the KafkaProducer. This allows integrators to avoid having to repeatedly trace each KafkaProducer that is sharing the same KafkaProducerConnection.

@aartigao aartigao added this to the v4.0.0 milestone Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants