Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Native HTTP port #28

Merged
merged 19 commits into from
Dec 1, 2021
Merged

feat: Native HTTP port #28

merged 19 commits into from
Dec 1, 2021

Conversation

mxthevs
Copy link
Contributor

@mxthevs mxthevs commented Oct 19, 2021

closes #27

@mxthevs mxthevs changed the title feat: Native HTTP port (WIP) feat: Native HTTP port Nov 1, 2021
@mxthevs
Copy link
Contributor Author

mxthevs commented Nov 1, 2021

Hey @fdaciuk,
I think this is good to go, all API tests are passing now.
Maybe we can review this live? It's up to you. I do think that this implementation has space for improvements. 😄

@fdaciuk
Copy link
Owner

fdaciuk commented Nov 1, 2021

Great idea! Let's review this tomorrow morning at stream! 👯 👯 ✨

fdaciuk
fdaciuk requested changes Nov 2, 2021
View reviewed changes
Copy link
Owner

@fdaciuk fdaciuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mxthevs congrats man, great work!

src/ports/native-http/index.ts Show resolved Hide resolved
src/ports/native-http/middlewares.ts Outdated Show resolved Hide resolved
src/ports/native-http/middlewares.ts Outdated Show resolved Hide resolved
src/ports/native-http/middlewares.ts Outdated Show resolved Hide resolved
src/ports/native-http/modules/article.ts Outdated Show resolved Hide resolved
src/ports/native-http/modules/article.ts Outdated Show resolved Hide resolved
src/ports/native-http/modules/article.ts Outdated Show resolved Hide resolved
src/ports/native-http/modules/article.ts Outdated Show resolved Hide resolved
src/ports/native-http/modules/profile.ts Outdated Show resolved Hide resolved
src/ports/native-http/modules/user.ts Outdated Show resolved Hide resolved
@fdaciuk fdaciuk merged commit 86d1aa1 into fdaciuk:main Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdaciuk fdaciuk fdaciuk approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Native HTTP module port implementation
2 participants
@mxthevs @fdaciuk