implement serialize/deserialize for Duration type in accordance with protobuf JSON spec #61
+94
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…protobuf JSON spec
|
Many thanks for putting this together! I will try to cut a new release in the next few weeks where this can included. |
|
One of the checks failed because rustc 1.70 is required. I just updated master to Prost 0.12.3 which also sets MSRV to 1.70.0. This should fix the failure. Can you merge/rebase your branch so the checks can pass? |
|
sorry I missed the notification from your earlier message! Let me know if there’s anything I can do here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #60.