-
Notifications
You must be signed in to change notification settings - Fork 483
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those changes look good. You might need to run cargo fmt
in order to make the CI pass. When my comments are addressed, I will merge and certainly released this in a "0.6.x" or something (given the public api breaking changes)
Any progress? |
I will handle the last comment, forgot that one. I think it can be merged right @fdehau ? |
.idea/codeStyles/Project.xml
Outdated
@@ -0,0 +1,29 @@ | |||
<component name="ProjectCodeStyleConfiguration"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remember to remove this file from the PR before it gets merged
@fdehau can this be merged? |
If you remove the .idea files, I would be happy to. |
done! LGTM ;) |
I updated to crossterm to 0.9.4 |
@@ -3,3 +3,4 @@ Cargo.lock | |||
*.log | |||
*.rs.rustfmt | |||
.gdb_history | |||
.idea/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, this would live in your git user config and not the repository. Not a blocker IMO
Updated the version of crossterm, notice that it has API breaking changes. The 0.9.^ version has a lot of improvements.
This is a continuation of #150, but that git history was ruined.