This repository has been archived by the owner on Aug 6, 2023. It is now read-only.
Update 0.9.4 #153
Merged
Update 0.9.4 #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdehau
suggested changes
Apr 26, 2019
|
Any progress? |
|
I will handle the last comment, forgot that one. I think it can be merged right @fdehau ? |
matprec
reviewed
May 7, 2019
.idea/codeStyles/Project.xml
Outdated
| @@ -0,0 +1,29 @@ | |||
| <component name="ProjectCodeStyleConfiguration"> | |||
There was a problem hiding this comment.
Remember to remove this file from the PR before it gets merged
|
@fdehau can this be merged? |
|
If you remove the .idea files, I would be happy to. |
|
done! LGTM ;) |
|
I updated to crossterm to 0.9.4 |
matprec
reviewed
May 16, 2019
| @@ -3,3 +3,4 @@ Cargo.lock | |||
| *.log | |||
| *.rs.rustfmt | |||
| .gdb_history | |||
| .idea/ | |||
There was a problem hiding this comment.
Ideally, this would live in your git user config and not the repository. Not a blocker IMO
This was referenced May 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the version of crossterm, notice that it has API breaking changes. The 0.9.^ version has a lot of improvements.
This is a continuation of #150, but that git history was ruined.