Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ngx_http_upload_module.c #115

Closed
wants to merge 1 commit into from

Conversation

passerbya
Copy link

Repair 1 byte in state file error: state file "***.state" is corrupt. Like this: 10-10/72845543

Repair 1 byte in state file error: state file "***.state" is corrupt. Like this: 10-10/72845543
@codecov
Copy link

codecov bot commented Dec 24, 2018

Codecov Report

Merging #115 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #115   +/-   ##
=======================================
  Coverage   72.26%   72.26%           
=======================================
  Files           1        1           
  Lines        1648     1648           
=======================================
  Hits         1191     1191           
  Misses        457      457
Impacted Files Coverage Δ
ngx_http_upload_module.c 72.26% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 666428b...6fc8cb3. Read the comment docs.

@passerbya
Copy link
Author

This bug is easy to reproduce. Execute the following command twice.

curl http://localhost:8081/upload/ -d a -H "Content-Type: text/xml" -H "Content-Disposition: attachment; filename=big.TXT" -H "X-Content-Range: bytes 1-1/111414930" -H "Session-ID: 1111215057" -v

The first execution of the command returns success, the state file created like this:1-1/111414930.
But the second execution of the command returns error: state file "***.state" is corrupt. The debug log show this: inconsistent bounds while parsing range: 1-1/111414930.

@passerbya
Copy link
Author

@vkholodkov @fdintino Could you please merge my code?

fdintino added a commit that referenced this pull request Jun 21, 2020
@fdintino fdintino closed this in 643b4c1 Jun 26, 2020
rounce pushed a commit to rounce/nginx-upload-module that referenced this pull request May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant