This repository has been archived by the owner on May 14, 2024. It is now read-only.
Hourann/fix panic at index out of bound #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm busy these days. Sorry for my late reply though. It’s been a long time since I made this PR and I can't remember many details. I think you should be more confident than me on this PR. And thank you for adding a test case. It looks fine as I just glance at it. Just check that the test case fails before we make this change and passes after we change it. Thank you again for trying to keep xray alive. It's an awesome project. I'm willing to contribute when I have more time. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@flappyBug sorry bothering you, but you think the test I added would be enough? Also, you find the test name could fit?
Thanks and sorry again 😬
Original PR: atom#172