Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/basic moonraker API client #3025

Merged
merged 6 commits into from
Mar 26, 2024
Merged

Conversation

davidzwa
Copy link
Collaborator

Description

Implements #2797

@davidzwa davidzwa force-pushed the feat/basic-moonraker-support branch from 46811a3 to 9f873b5 Compare March 23, 2024 13:50
Copy link

codecov bot commented Mar 23, 2024

Codecov Report

Attention: Patch coverage is 9.95671% with 208 lines in your changes are missing coverage. Please review.

Project coverage is 68.94%. Comparing base (c3a6753) to head (b947d87).

❗ Current head b947d87 differs from pull request most recent head 30e63b7. Consider uploading reports for the commit 30e63b7 to get more accurate results

Files Patch % Lines
src/services/moonraker/moonraker.client.ts 6.19% 197 Missing ⚠️
...ervices/moonraker/moonraker-subscription.client.ts 0.00% 11 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3025      +/-   ##
===========================================
- Coverage    70.64%   68.94%   -1.71%     
===========================================
  Files          205      207       +2     
  Lines         8119     8342     +223     
  Branches       926     1011      +85     
===========================================
+ Hits          5736     5751      +15     
- Misses        2382     2590     +208     
  Partials         1        1              
Flag Coverage Δ
server-nodejs 68.94% <9.95%> (-1.71%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidzwa davidzwa force-pushed the feat/basic-moonraker-support branch from fb3f856 to b947d87 Compare March 24, 2024 07:50
@davidzwa davidzwa force-pushed the feat/basic-moonraker-support branch from 0312919 to 30e63b7 Compare March 26, 2024 18:59
@davidzwa davidzwa changed the title Feat/basic moonraker support Feat/basic moonraker API client Mar 26, 2024
@davidzwa davidzwa merged commit 72d0728 into develop Mar 26, 2024
5 checks passed
@davidzwa davidzwa deleted the feat/basic-moonraker-support branch March 26, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant