Merge existing fixes and some new performance enhancements #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge MongoReplicaClient support from centum
…ngodb-plugin into pklaus-error-message-fix Conflicts: bottle_mongo.py
Plugins and Bottle Framework to PyPI's classifiers
* Removed a check for a null json_dumps that can never be null. * Only wrap the callback if there is something to be done to the callback. * Remove support for returning lists. Due to security problems in browsers, it is not advisable to return lists as the top level item in a JSON response to a GET request. Removing the default support for it, so in scenarios where it would be supportable (POST for example), it is better to be explicit about what is happening. See http://haacked.com/archive/2009/06/24/json-hijacking.aspx for details on the problem. * Small cleanups for pep8 and pep257
Bottle applies a uniqueness filter to the plugins when applying them, so to support multiple instances of the same plugin, each instance needs a unique name.
This lets the user add things like the SONManipulators to the database object created by the plugin.
|
Hey guys, talk about bottle-mongodb with bottle core team, like this this for over 2 years without contributions we create a new project (fork) in the organization of the bottle! new project: https://github.com/bottlepy/bottle-mongo history: bottlepy/bottle-extras#24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have gathered up other people's fixes I found on GitHub and made a few improvements like:
supporting egg distributions
Removed a check for a null json_dumps that can never be null.
Only wrap the callback if there is something to be done to the callback.
Remove support for returning lists.
Due to security problems in browsers, it is not advisable to return
lists as the top level item in a JSON response to a GET request.
Removing the default support for it, so in scenarios where it would be
supportable (POST for example), it is better to be explicit about what
is happening. See
http://haacked.com/archive/2009/06/24/json-hijacking.aspx for details
on the problem.
Small cleanups for pep8 and pep257
I bumped the version number in the setup to 0.2.1.2, and if you accept this pull request, it would be great if you could push an update to PyPI.