[Possible Bug] Items with newlines in the user field crash the application

[psfloyd]

Hi, today I downloaded rofi-rbw, and had some problems getting it to work. The issue is resolved for my case now, but maybe it can lead to a bug fix in the code for the future. Or information for someone that has a similar problem.
I was getting this error:

Traceback (most recent call last):
  File "/usr/bin/rofi-rbw", line 8, in <module>
    sys.exit(main())
  File "/usr/lib/python3.10/site-packages/rofi_rbw/rofi_rbw.py", line 231, in main
    RofiRbw().main()
  File "/usr/lib/python3.10/site-packages/rofi_rbw/rofi_rbw.py", line 132, in main
    parsed_entries = [Entry.parse_rbw_output(it) for it in entries]
  File "/usr/lib/python3.10/site-packages/rofi_rbw/rofi_rbw.py", line 132, in <listcomp>
    parsed_entries = [Entry.parse_rbw_output(it) for it in entries]
  File "/usr/lib/python3.10/site-packages/rofi_rbw/entry.py", line 33, in parse_rbw_output
    fields[1],
IndexError: list index out of range

I inspected the output of rbw ls --fields 'folder,name,user' as per this issue #38. And found that the output had some empty lines.
I do not know how, but for some reason I had an item in my bitwarden vault that had a newline in the user field. This was not intended, so I fixed this entry.
I could not replicate the entry in bitwarden. It is not possible to insert newlines on the user field.

But I think this might be an edge case to consider.

[fdw]

Thanks for that information! 🙂

I don't think rofi-rbw can do much here, as I have no idea what exactly is the problem with an incorrectly formatted line. I've tried at least to improve the error message a bit, so that at least it's easier to see what the problem is. But if you have a better idea, please share 🙂

[psfloyd]

Great!
A better error message is very helpful for this type of issue.
I'm going to close the issue, as it is resolved on my case.