Collection range indices #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
reima
reviewed
Oct 4, 2023
Code/Light.GuardClauses.Tests/ComparableAssertions/RangeTests.cs
Outdated
Show resolved
Hide resolved
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
I optimized the new GetCount method so that it also supports IReadOnlyCollection<T> and ICollection<T> properly. It's now faster in .NET 7 than the LINQ Count method on Windows and Linux. Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
|
@reima if you want to, we can merge this PR |
reima
reviewed
Oct 8, 2023
Code/Light.GuardClauses.Tests/ComparableAssertions/RangeTests.cs
Outdated
Show resolved
Hide resolved
|
@feO2x Yes, let's merge it! Thank you for your efforts and gathering my feedback along the way. I appreciate it. |
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #93
In addition to the new
Range.Foroverloads, I also fixed the tests that break in newer .NET versions (because of enums being extended andEnumerable.Rangeno longer being lazily evaluated).