add support for redis auth (#106)

* add support for redis auth Signed-off-by: Khor Shu Heng <khor.heng@go-jek.com> * use setup.py Signed-off-by: Khor Shu Heng <khor.heng@go-jek.com> * remove gcp and aws e2e Signed-off-by: Khor Shu Heng <khor.heng@go-jek.com> * rename auth to password for clarity Signed-off-by: Khor Shu Heng <khor.heng@go-jek.com>
feast-dev · Feb 4, 2022 · b2e7426 · b2e7426
1 parent ecd77c8
commit b2e7426
Show file tree

Hide file tree

Showing 11 changed files with 40 additions and 379 deletions.
diff --git a/.prow.yaml b/.prow.yaml
@@ -1,66 +1,4 @@
 presubmits:
-- name: test-end-to-end-gcp
-  decorate: true
-  always_run: true
-  max_concurrency: 1
-  spec:
-    containers:
-    - image: gcr.io/kf-feast/feast-ci:latest
-      command: [ "infra/scripts/test-end-to-end-gcp.sh" ]
-      resources:
-        requests:
-          cpu: "6"
-          memory: "6144Mi"
-      env:
-        - name: GOOGLE_APPLICATION_CREDENTIALS
-          value: /etc/gcloud/service-account.json
-      volumeMounts:
-        - mountPath: /etc/gcloud/service-account.json
-          name: service-account
-          readOnly: true
-          subPath: service-account.json
-    volumes:
-      - name: service-account
-        secret:
-          secretName: feast-service-account
-- name: test-end-to-end-aws
-  decorate: true
-  always_run: true
-  max_concurrency: 1
-  spec:
-    containers:
-      - image: gcr.io/kf-feast/feast-ci:latest
-        command: [ "infra/scripts/aws-runner.sh", "--location-from-prow", "--project-name", "feast-ci-project"  ]
-        resources:
-          requests:
-            cpu: "2"
-            memory: "2Gi"
-        env:
-          - name: GOOGLE_APPLICATION_CREDENTIALS
-            value: /etc/gcloud/service-account.json
-          - name: DOCKER_REPOSITORY
-            value: gcr.io/kf-feast
-          - name: AWS_ACCESS_KEY_ID
-            valueFrom:
-              secretKeyRef:
-                name: feast-aws-creds
-                key: AWS_ACCESS_KEY_ID
-          - name: AWS_SECRET_ACCESS_KEY
-            valueFrom:
-              secretKeyRef:
-                name: feast-aws-creds
-                key: AWS_SECRET_ACCESS_KEY
-          - name: AWS_DEFAULT_REGION
-            value: us-west-2
-        volumeMounts:
-          - mountPath: /etc/gcloud/service-account.json
-            name: service-account
-            readOnly: true
-            subPath: service-account.json
-    volumes:
-      - name: service-account
-        secret:
-          secretName: feast-service-account
 - name: test-end-to-end-sparkop
   decorate: true
   always_run: true
@@ -90,134 +28,7 @@ presubmits:
         secret:
           secretName: feast-service-account
 
-
-#- name: test-end-to-end-azure
-#  decorate: true
-#  always_run: true
-#  max_concurrency: 1
-#  spec:
-#    containers:
-#    - image: gcr.io/kf-feast/feast-ci:develop
-#      command: [ "infra/scripts/azure-runner.sh" ]
-#      resources:
-#        requests:
-#          cpu: "2"
-#          memory: "2048Mi"
-#      env:
-#        - name: GOOGLE_APPLICATION_CREDENTIALS
-#          value: /etc/gcloud/service-account.json
-#        - name: RESOURCE_GROUP
-#          value: Feast
-#        - name: AKS_CLUSTER_NAME
-#          value: main
-#        - name: DOCKER_REPOSITORY
-#          value: gcr.io/kf-feast
-#        - name: STAGING_PATH
-#          value: wasbs://staging@feastcicd.blob.core.windows.net/cicd-staging
-#        - name: AZ_SERVICE_PRINCIPAL_ID
-#          valueFrom:
-#            secretKeyRef:
-#              name: feast-az-creds
-#              key: AZ_SERVICE_PRINCIPAL_ID
-#        - name: AZ_SERVICE_PRINCIPAL_PASS
-#          valueFrom:
-#            secretKeyRef:
-#              name: feast-az-creds
-#              key: AZ_SERVICE_PRINCIPAL_PASS
-#        - name: AZ_SERVICE_PRINCIPAL_TENANT_ID
-#          valueFrom:
-#            secretKeyRef:
-#              name: feast-az-creds
-#              key: AZ_SERVICE_PRINCIPAL_TENANT_ID
-#        - name: AZURE_BLOB_ACCOUNT_NAME
-#          valueFrom:
-#            secretKeyRef:
-#              name: feast-az-creds
-#              key: AZURE_BLOB_ACCOUNT_NAME
-#        - name: AZURE_BLOB_ACCOUNT_ACCESS_KEY
-#          valueFrom:
-#            secretKeyRef:
-#              name: feast-az-creds
-#              key: AZURE_BLOB_ACCOUNT_ACCESS_KEY
-#      volumeMounts:
-#        - mountPath: /etc/gcloud/service-account.json
-#          name: service-account
-#          readOnly: true
-#          subPath: service-account.json
-#    volumes:
-#      - name: service-account
-#        secret:
-#          secretName: feast-service-account
-
 postsubmits:
-- name: test-end-to-end-gcp
-  decorate: true
-  always_run: true
-  max_concurrency: 1
-  branches:
-    - ^master$
-  spec:
-    containers:
-    - image: gcr.io/kf-feast/feast-ci:latest
-      command: [ "infra/scripts/test-end-to-end-gcp.sh" ]
-      resources:
-        requests:
-          cpu: "6"
-          memory: "6144Mi"
-      env:
-        - name: GOOGLE_APPLICATION_CREDENTIALS
-          value: /etc/gcloud/service-account.json
-      volumeMounts:
-        - mountPath: /etc/gcloud/service-account.json
-          name: service-account
-          readOnly: true
-          subPath: service-account.json
-    volumes:
-      - name: service-account
-        secret:
-          secretName: feast-service-account
-
-- name: test-end-to-end-aws
-  decorate: true
-  always_run: true
-  max_concurrency: 1
-  branches:
-    - ^master$
-  spec:
-    containers:
-      - image: gcr.io/kf-feast/feast-ci:latest
-        command: [ "infra/scripts/aws-runner.sh", "--location-from-prow", "--project-name", "feast-ci-project" ]
-        resources:
-          requests:
-            cpu: "2"
-            memory: "2048Mi"
-        env:
-          - name: GOOGLE_APPLICATION_CREDENTIALS
-            value: /etc/gcloud/service-account.json
-          - name: DOCKER_REPOSITORY
-            value: gcr.io/kf-feast
-          - name: AWS_ACCESS_KEY_ID
-            valueFrom:
-              secretKeyRef:
-                name: feast-aws-creds
-                key: AWS_ACCESS_KEY_ID
-          - name: AWS_SECRET_ACCESS_KEY
-            valueFrom:
-              secretKeyRef:
-                name: feast-aws-creds
-                key: AWS_SECRET_ACCESS_KEY
-          - name: AWS_DEFAULT_REGION
-            value: us-west-2
-        volumeMounts:
-          - mountPath: /etc/gcloud/service-account.json
-            name: service-account
-            readOnly: true
-            subPath: service-account.json
-    volumes:
-      - name: service-account
-        secret:
-          secretName: feast-service-account
-
 - name: test-end-to-end-sparkop
   decorate: true
   always_run: true
@@ -248,63 +59,3 @@ postsubmits:
       - name: service-account
         secret:
           secretName: feast-service-account
-
-#- name: test-end-to-end-azure
-#  decorate: true
-#  always_run: true
-#  max_concurrency: 1
-#  branches:
-#    - ^master$
-#  spec:
-#    containers:
-#    - image: gcr.io/kf-feast/feast-ci:develop
-#      command: [ "infra/scripts/azure-runner.sh" ]
-#      resources:
-#        requests:
-#          cpu: "2"
-#          memory: "2048Mi"
-#      env:
-#        - name: GOOGLE_APPLICATION_CREDENTIALS
-#          value: /etc/gcloud/service-account.json
-#        - name: RESOURCE_GROUP
-#          value: Feast
-#        - name: AKS_CLUSTER_NAME
-#          value: main
-#        - name: DOCKER_REPOSITORY
-#          value: gcr.io/kf-feast
-#        - name: STAGING_PATH
-#          value: wasbs://staging@feastcicd.blob.core.windows.net/cicd-staging
-#        - name: AZ_SERVICE_PRINCIPAL_ID
-#          valueFrom:
-#            secretKeyRef:
-#              name: feast-az-creds
-#              key: AZ_SERVICE_PRINCIPAL_ID
-#        - name: AZ_SERVICE_PRINCIPAL_PASS
-#          valueFrom:
-#            secretKeyRef:
-#              name: feast-az-creds
-#              key: AZ_SERVICE_PRINCIPAL_PASS
-#        - name: AZ_SERVICE_PRINCIPAL_TENANT_ID
-#          valueFrom:
-#            secretKeyRef:
-#              name: feast-az-creds
-#              key: AZ_SERVICE_PRINCIPAL_TENANT_ID
-#        - name: AZURE_BLOB_ACCOUNT_NAME
-#          valueFrom:
-#            secretKeyRef:
-#              name: feast-az-creds
-#              key: AZURE_BLOB_ACCOUNT_NAME
-#        - name: AZURE_BLOB_ACCOUNT_ACCESS_KEY
-#          valueFrom:
-#            secretKeyRef:
-#              name: feast-az-creds
-#              key: AZURE_BLOB_ACCOUNT_ACCESS_KEY
-#      volumeMounts:
-#        - mountPath: /etc/gcloud/service-account.json
-#          name: service-account
-#          readOnly: true
-#          subPath: service-account.json
-#    volumes:
-#      - name: service-account
-#        secret:
-#          secretName: feast-service-account
diff --git a/Makefile b/Makefile
@@ -34,7 +34,7 @@ install-python-ci-dependencies:
 
 # Supports feast-dev repo master branch
 install-python: install-python-ci-dependencies
-	cd ${ROOT_DIR}; python -m pip install -e python
+	cd ${ROOT_DIR}/python; python setup.py install
 
 lint-python:
 	cd ${ROOT_DIR}/python ; mypy feast_spark/ tests/

diff --git a/infra/scripts/test-end-to-end-aws.sh b/infra/scripts/test-end-to-end-aws.sh
diff --git a/infra/scripts/test-end-to-end-azure.sh b/infra/scripts/test-end-to-end-azure.sh