Skip to content

Commit

Permalink
Fix failing tests (#1450)
Browse files Browse the repository at this point in the history
* Ignore protos for flake8 check

Signed-off-by: Terence Lim <terencelimxp@gmail.com>

* Install missing dependencies

Signed-off-by: Terence Lim <terencelimxp@gmail.com>

* Bump testcontainers version

Signed-off-by: Terence Lim <terencelimxp@gmail.com>

* Update kubectl version

Signed-off-by: Terence Lim <terencelimxp@gmail.com>

* Revert kubectl version

Signed-off-by: Terence Lim <terencelimxp@gmail.com>
  • Loading branch information
terryyylim committed Apr 9, 2021
1 parent aa12b58 commit 00c8f63
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/complete.yml
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,8 @@ jobs:
container: gcr.io/kf-feast/feast-ci:latest
steps:
- uses: actions/checkout@v2
- name: Install dependencies
run: make install-python-ci-dependencies
- name: Install python
run: make install-python
- name: Test python
Expand Down
6 changes: 3 additions & 3 deletions common-test/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -106,17 +106,17 @@
<dependency>
<groupId>org.testcontainers</groupId>
<artifactId>junit-jupiter</artifactId>
<version>1.15.0</version>
<version>1.15.1</version>
</dependency>
<dependency>
<groupId>org.testcontainers</groupId>
<artifactId>postgresql</artifactId>
<version>1.15.0</version>
<version>1.15.1</version>
</dependency>
<dependency>
<groupId>org.testcontainers</groupId>
<artifactId>kafka</artifactId>
<version>1.15.0</version>
<version>1.15.1</version>
</dependency>
<dependency>
<groupId>org.junit.jupiter</groupId>
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ ignore = E203, E266, E501, W503
max-line-length = 88
max-complexity = 20
select = B,C,E,F,W,T4
exclude = .git,__pycache__,docs/conf.py,dist,feast/core,feast/serving,feast/types,feast/storage,feast/third_party
exclude = .git,__pycache__,docs/conf.py,dist,feast/core,feast/serving,feast/types,feast/storage,feast/third_party,feast/protos

[mypy]
files=feast,test
Expand Down

0 comments on commit 00c8f63

Please sign in to comment.