Skip to content

Commit

Permalink
Move OfflineStore into Provider (#1437)
Browse files Browse the repository at this point in the history
Signed-off-by: Willem Pienaar <git@willem.co>
  • Loading branch information
woop committed Apr 4, 2021
1 parent cd75008 commit 305842f
Show file tree
Hide file tree
Showing 7 changed files with 605 additions and 654 deletions.
2 changes: 1 addition & 1 deletion sdk/python/feast/driver_test_data.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import numpy as np
import pandas as pd

from feast.offline_store import ENTITY_DF_EVENT_TIMESTAMP_COL
from feast.infra.provider import ENTITY_DF_EVENT_TIMESTAMP_COL


def create_orders_df(
Expand Down
16 changes: 5 additions & 11 deletions sdk/python/feast/feature_store.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,7 @@

from feast.entity import Entity
from feast.feature_view import FeatureView
from feast.infra.provider import Provider, get_provider
from feast.offline_store import (
RetrievalJob,
get_offline_store,
get_offline_store_for_retrieval,
)
from feast.infra.provider import Provider, RetrievalJob, get_provider
from feast.online_response import OnlineResponse, _infer_online_entity_rows
from feast.protos.feast.serving.ServingService_pb2 import (
GetOnlineFeaturesRequestV2,
Expand Down Expand Up @@ -255,8 +250,8 @@ def get_historical_features(
project=self.config.project
)
feature_views = _get_requested_feature_views(feature_refs, all_feature_views)
offline_store = get_offline_store_for_retrieval(feature_views)
job = offline_store.get_historical_features(
provider = self._get_provider()
job = provider.get_historical_features(
self.config, feature_views, feature_refs, entity_df
)
return job
Expand Down Expand Up @@ -367,9 +362,8 @@ def _materialize_single_feature_view(
event_timestamp_column,
created_timestamp_column,
) = _run_reverse_field_mapping(feature_view)

offline_store = get_offline_store(self.config)
table = offline_store.pull_latest_from_table_or_query(
provider = self._get_provider()
table = provider.pull_latest_from_table_or_query(
feature_view.input,
entity_names,
feature_names,
Expand Down

0 comments on commit 305842f

Please sign in to comment.