Skip to content

Commit

Permalink
Fix noisy path warning (#1452)
Browse files Browse the repository at this point in the history
Signed-off-by: Willem Pienaar <git@willem.co>
  • Loading branch information
woop committed Apr 9, 2021
1 parent 3f0435d commit 41a7a4a
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions sdk/python/feast/data_source.py
Original file line number Diff line number Diff line change
Expand Up @@ -456,7 +456,7 @@ def from_proto(data_source):
data_source_obj = FileSource(
field_mapping=data_source.field_mapping,
file_format=FileFormat.from_proto(data_source.file_options.file_format),
file_url=data_source.file_options.file_url,
path=data_source.file_options.file_url,
event_timestamp_column=data_source.event_timestamp_column,
created_timestamp_column=data_source.created_timestamp_column,
date_partition_column=data_source.date_partition_column,
Expand Down Expand Up @@ -553,8 +553,7 @@ def __init__(
raise ValueError(
'No "path" argument provided. Please set "path" to the location of your file source.'
)

if file_url is not None:
if file_url:
from warnings import warn

warn(
Expand Down

0 comments on commit 41a7a4a

Please sign in to comment.