fix: Use configured user in env var instead of "user" for Trino (#3254)

* use env var user Signed-off-by: ammarar <ammar.alrashed@gmail.com> * lint fix Signed-off-by: ammarar <ammar.alrashed@gmail.com> Signed-off-by: ammarar <ammar.alrashed@gmail.com>
feast-dev · Sep 29, 2022 · 532d8a1 · 532d8a1
1 parent b851e01
commit 532d8a1
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/sdk/python/feast/infra/offline_stores/contrib/trino_offline_store/trino.py b/sdk/python/feast/infra/offline_stores/contrib/trino_offline_store/trino.py
@@ -157,7 +157,7 @@ def pull_latest_from_table_or_query(
         created_timestamp_column: Optional[str],
         start_date: datetime,
         end_date: datetime,
-        user: str = "user",
+        user: Optional[str] = None,
         auth: Optional[Authentication] = None,
         http_scheme: Optional[str] = None,
     ) -> TrinoRetrievalJob:
@@ -176,7 +176,6 @@ def pull_latest_from_table_or_query(
             timestamps.append(created_timestamp_column)
         timestamp_desc_string = " DESC, ".join(timestamps) + " DESC"
         field_string = ", ".join(join_key_columns + feature_name_columns + timestamps)
-
         client = _get_trino_client(
             config=config, user=user, auth=auth, http_scheme=http_scheme
         )
@@ -212,7 +211,7 @@ def get_historical_features(
         registry: Registry,
         project: str,
         full_feature_names: bool = False,
-        user: str = "user",
+        user: Optional[str] = None,
         auth: Optional[Authentication] = None,
         http_scheme: Optional[str] = None,
     ) -> TrinoRetrievalJob:
@@ -303,7 +302,7 @@ def pull_all_from_table_or_query(
         timestamp_field: str,
         start_date: datetime,
         end_date: datetime,
-        user: str = "user",
+        user: Optional[str] = None,
         auth: Optional[Authentication] = None,
         http_scheme: Optional[str] = None,
     ) -> RetrievalJob:
@@ -375,7 +374,10 @@ def _upload_entity_df_and_get_entity_schema(
 
 
 def _get_trino_client(
-    config: RepoConfig, user: str, auth: Optional[Any], http_scheme: Optional[str]
+    config: RepoConfig,
+    user: Optional[str],
+    auth: Optional[Any],
+    http_scheme: Optional[str],
 ) -> Trino:
     client = Trino(
         user=user,