Skip to content

Commit

Permalink
incorporating code review comments from Daniel
Browse files Browse the repository at this point in the history
Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com>

Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com>
  • Loading branch information
lokeshrangineni committed Jun 12, 2024
1 parent 8ee2df3 commit 7e324ae
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions sdk/python/tests/integration/feature_repos/repo_configuration.py
Original file line number Diff line number Diff line change
Expand Up @@ -465,6 +465,13 @@ def construct_test_environment(
project, fixture_request=fixture_request
)

if test_repo_config.online_store_creator:
online_creator = test_repo_config.online_store_creator(
project, fixture_request=fixture_request
)
else:
online_creator = None

if test_repo_config.python_feature_server and test_repo_config.provider == "aws":
from feast.infra.feature_servers.aws_lambda.config import (
AwsLambdaFeatureServerConfig,
Expand Down Expand Up @@ -498,13 +505,6 @@ def construct_test_environment(
cache_ttl_seconds=1,
)

if test_repo_config.online_store_creator:
online_creator = test_repo_config.online_store_creator(
project, fixture_request=fixture_request, registry_path=registry.path
)
else:
online_creator = None

environment = Environment(
name=project,
provider=test_repo_config.provider,
Expand Down

0 comments on commit 7e324ae

Please sign in to comment.