Skip to content

Commit

Permalink
fix: Fix release workflow to release 0.24.0 (#3138)
Browse files Browse the repository at this point in the history
* Fix

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

* fix

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

* temporary fix

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

* Fix

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

* Fix

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

* Fix

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
  • Loading branch information
kevjumba committed Aug 25, 2022
1 parent 9f78367 commit a69aaae
Show file tree
Hide file tree
Showing 2 changed files with 35 additions and 32 deletions.
7 changes: 5 additions & 2 deletions .github/workflows/build_wheels.yml
Expand Up @@ -89,6 +89,7 @@ jobs:
make install-go-ci-dependencies
git status
git restore go.mod go.sum
git restore sdk/python/feast/ui/yarn.lock
CIBW_BEFORE_TEST: "cd {project} && git status"
# py3.10 on MacOS does not work with Go so we have to install separately. Issue is tracked here: https://github.com/feast-dev/feast/issues/2881.
- name: Build py310 specific wheels for macos
Expand All @@ -104,6 +105,7 @@ jobs:
CIBW_BEFORE_BUILD: |
git status
git restore go.mod go.sum
git restore sdk/python/feast/ui/yarn.lock
brew install apache-arrow
- uses: actions/upload-artifact@v2
with:
Expand Down Expand Up @@ -136,6 +138,7 @@ jobs:
make build-ui
git status
git restore go.mod go.sum
git restore sdk/python/feast/ui/yarn.lock
- name: Build
run: |
python3 setup.py sdist
Expand Down Expand Up @@ -232,7 +235,7 @@ jobs:
- name: Smoke test
run: |
feast init test_repo
cd test_repo/
cd test_repo/feature_repo
feast apply
echo "$TEST_SCRIPT" > run-and-wait.sh
bash run-and-wait.sh feast serve
Expand All @@ -241,7 +244,7 @@ jobs:
- name: Smoke test with go
if: matrix.python-version != '3.10' || matrix.os == 'ubuntu-latest'
run: |
cd test_repo/
cd test_repo/feature_repo
feast apply
echo "$TEST_SCRIPT" > run-and-wait.sh
pip install cffi
Expand Down
60 changes: 30 additions & 30 deletions .github/workflows/release.yml
Expand Up @@ -42,40 +42,40 @@ jobs:
echo "Current version is ${CURRENT_VERSION}"
echo "Next version is ${NEXT_VERSION}"
publish-web-ui-npm:
if: github.repository == 'feast-dev/feast'
needs: get_dry_release_versions
runs-on: ubuntu-latest
env:
# This publish is working using an NPM automation token to bypass 2FA
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
CURRENT_VERSION: ${{ needs.get_dry_release_versions.outputs.current_version }}
NEXT_VERSION: ${{ needs.get_dry_release_versions.outputs.next_version }}
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
with:
node-version: '17.x'
registry-url: 'https://registry.npmjs.org'
- name: Bump file versions (temporarily for Web UI publish)
run: python ./infra/scripts/release/bump_file_versions.py ${CURRENT_VERSION} ${NEXT_VERSION}
- name: Install yarn dependencies
working-directory: ./ui
run: yarn install
- name: Build yarn rollup
working-directory: ./ui
run: yarn build:lib
- name: Publish UI package
working-directory: ./ui
run: npm publish
env:
# This publish is working using an NPM automation token to bypass 2FA
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
# publish-web-ui-npm:
# if: github.repository == 'feast-dev/feast'
# needs: get_dry_release_versions
# runs-on: ubuntu-latest
# env:
# # This publish is working using an NPM automation token to bypass 2FA
# NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
# CURRENT_VERSION: ${{ needs.get_dry_release_versions.outputs.current_version }}
# NEXT_VERSION: ${{ needs.get_dry_release_versions.outputs.next_version }}
# steps:
# - uses: actions/checkout@v2
# - uses: actions/setup-node@v2
# with:
# node-version: '17.x'
# registry-url: 'https://registry.npmjs.org'
# - name: Bump file versions (temporarily for Web UI publish)
# run: python ./infra/scripts/release/bump_file_versions.py ${CURRENT_VERSION} ${NEXT_VERSION}
# - name: Install yarn dependencies
# working-directory: ./ui
# run: yarn install
# - name: Build yarn rollup
# working-directory: ./ui
# run: yarn build:lib
# - name: Publish UI package
# working-directory: ./ui
# run: npm publish
# env:
# # This publish is working using an NPM automation token to bypass 2FA
# NPM_TOKEN: ${{ secrets.NPM_TOKEN }}

release:
name: release
runs-on: ubuntu-latest
needs: publish-web-ui-npm
#needs: publish-web-ui-npm
env:
GITHUB_TOKEN: ${{ github.event.inputs.token }}
GIT_AUTHOR_NAME: feast-ci-bot
Expand Down

0 comments on commit a69aaae

Please sign in to comment.