Skip to content

Commit

Permalink
fix: Remove ci extra from the feature transformation server dockerfile (
Browse files Browse the repository at this point in the history
#2618)

* fix: Remove ci extra from the feature transformation server dockerfile and pin numpy for py3.7 support

Signed-off-by: Achal Shah <achals@gmail.com>

* remove debug

Signed-off-by: Achal Shah <achals@gmail.com>

* pin requirements

Signed-off-by: Achal Shah <achals@gmail.com>
  • Loading branch information
achals authored and kevjumba committed Apr 28, 2022
1 parent 40962fc commit a7437fa
Show file tree
Hide file tree
Showing 12 changed files with 44 additions and 621 deletions.

This file was deleted.

2 changes: 1 addition & 1 deletion sdk/python/feast/infra/transformation_servers/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ COPY protos protos
COPY README.md README.md

# Install dependencies
RUN pip3 install -e 'sdk/python[ci]'
RUN pip3 install -e 'sdk/python'

# Start feature transformation server
CMD [ "python", "app.py" ]
10 changes: 9 additions & 1 deletion sdk/python/requirements/py3.10-ci-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,8 @@ grpcio-tools==1.44.0
# via feast (setup.py)
h11==0.13.0
# via uvicorn
happybase==1.2.0
# via feast (setup.py)
hiredis==2.0.0
# via feast (setup.py)
httplib2==0.20.4
Expand Down Expand Up @@ -356,9 +358,10 @@ nbformat==5.3.0
# via great-expectations
nodeenv==1.6.0
# via pre-commit
numpy==1.22.3
numpy==1.21.6
# via
# altair
# feast (setup.py)
# great-expectations
# pandas
# pandavro
Expand Down Expand Up @@ -407,6 +410,8 @@ platformdirs==2.5.1
# via virtualenv
pluggy==1.0.0
# via pytest
ply==3.11
# via thriftpy2
portalocker==2.4.0
# via msal-extensions
pre-commit==2.18.1
Expand Down Expand Up @@ -594,6 +599,7 @@ six==1.16.0
# google-cloud-core
# google-resumable-media
# grpcio
# happybase
# mock
# msrestazure
# pandavro
Expand Down Expand Up @@ -638,6 +644,8 @@ termcolor==1.1.0
# via great-expectations
testcontainers==3.5.3
# via feast (setup.py)
thriftpy2==0.4.14
# via happybase
toml==0.10.2
# via
# black
Expand Down
3 changes: 2 additions & 1 deletion sdk/python/requirements/py3.10-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,9 @@ markupsafe==2.1.1
# via jinja2
mmh3==3.0.0
# via feast (setup.py)
numpy==1.22.3
numpy==1.21.6
# via
# feast (setup.py)
# pandas
# pandavro
# pyarrow
Expand Down
11 changes: 8 additions & 3 deletions sdk/python/requirements/py3.7-ci-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,8 @@ grpcio-tools==1.44.0
# via feast (setup.py)
h11==0.13.0
# via uvicorn
happybase==1.2.0
# via feast (setup.py)
hiredis==2.0.0
# via feast (setup.py)
httplib2==0.20.4
Expand Down Expand Up @@ -430,6 +432,7 @@ notebook==6.4.10
numpy==1.21.5
# via
# altair
# feast (setup.py)
# great-expectations
# pandas
# pandavro
Expand Down Expand Up @@ -481,6 +484,8 @@ platformdirs==2.5.1
# via virtualenv
pluggy==1.0.0
# via pytest
ply==3.11
# via thriftpy2
portalocker==2.4.0
# via msal-extensions
pre-commit==2.17.0
Expand Down Expand Up @@ -682,7 +687,7 @@ six==1.16.0
# google-cloud-core
# google-resumable-media
# grpcio
# isodate
# happybase
# mock
# msrestazure
# pandavro
Expand Down Expand Up @@ -727,8 +732,8 @@ terminado==0.13.2
# via notebook
testcontainers==3.5.3
# via feast (setup.py)
testpath==0.6.0
# via nbconvert
thriftpy2==0.4.14
# via happybase
toml==0.10.2
# via
# black
Expand Down
1 change: 1 addition & 0 deletions sdk/python/requirements/py3.7-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ mmh3==3.0.0
# via feast (setup.py)
numpy==1.21.5
# via
# feast (setup.py)
# pandas
# pandavro
# pyarrow
Expand Down
10 changes: 9 additions & 1 deletion sdk/python/requirements/py3.8-ci-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,8 @@ grpcio-tools==1.44.0
# via feast (setup.py)
h11==0.13.0
# via uvicorn
happybase==1.2.0
# via feast (setup.py)
hiredis==2.0.0
# via feast (setup.py)
httplib2==0.20.4
Expand Down Expand Up @@ -362,9 +364,10 @@ nbformat==5.3.0
# via great-expectations
nodeenv==1.6.0
# via pre-commit
numpy==1.22.3
numpy==1.21.6
# via
# altair
# feast (setup.py)
# great-expectations
# pandas
# pandavro
Expand Down Expand Up @@ -413,6 +416,8 @@ platformdirs==2.5.1
# via virtualenv
pluggy==1.0.0
# via pytest
ply==3.11
# via thriftpy2
portalocker==2.4.0
# via msal-extensions
pre-commit==2.18.1
Expand Down Expand Up @@ -602,6 +607,7 @@ six==1.16.0
# google-cloud-core
# google-resumable-media
# grpcio
# happybase
# mock
# msrestazure
# pandavro
Expand Down Expand Up @@ -646,6 +652,8 @@ termcolor==1.1.0
# via great-expectations
testcontainers==3.5.3
# via feast (setup.py)
thriftpy2==0.4.14
# via happybase
toml==0.10.2
# via
# black
Expand Down
3 changes: 2 additions & 1 deletion sdk/python/requirements/py3.8-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,9 @@ markupsafe==2.1.1
# via jinja2
mmh3==3.0.0
# via feast (setup.py)
numpy==1.22.3
numpy==1.21.6
# via
# feast (setup.py)
# pandas
# pandavro
# pyarrow
Expand Down
10 changes: 9 additions & 1 deletion sdk/python/requirements/py3.9-ci-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,8 @@ grpcio-tools==1.44.0
# via feast (setup.py)
h11==0.13.0
# via uvicorn
happybase==1.2.0
# via feast (setup.py)
hiredis==2.0.0
# via feast (setup.py)
httplib2==0.20.4
Expand Down Expand Up @@ -356,9 +358,10 @@ nbformat==5.3.0
# via great-expectations
nodeenv==1.6.0
# via pre-commit
numpy==1.22.3
numpy==1.21.6
# via
# altair
# feast (setup.py)
# great-expectations
# pandas
# pandavro
Expand Down Expand Up @@ -407,6 +410,8 @@ platformdirs==2.5.1
# via virtualenv
pluggy==1.0.0
# via pytest
ply==3.11
# via thriftpy2
portalocker==2.4.0
# via msal-extensions
pre-commit==2.18.1
Expand Down Expand Up @@ -596,6 +601,7 @@ six==1.16.0
# google-cloud-core
# google-resumable-media
# grpcio
# happybase
# mock
# msrestazure
# pandavro
Expand Down Expand Up @@ -640,6 +646,8 @@ termcolor==1.1.0
# via great-expectations
testcontainers==3.5.3
# via feast (setup.py)
thriftpy2==0.4.14
# via happybase
toml==0.10.2
# via
# black
Expand Down
3 changes: 2 additions & 1 deletion sdk/python/requirements/py3.9-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,9 @@ markupsafe==2.1.1
# via jinja2
mmh3==3.0.0
# via feast (setup.py)
numpy==1.22.3
numpy==1.21.6
# via
# feast (setup.py)
# pandas
# pandavro
# pyarrow
Expand Down
1 change: 1 addition & 0 deletions sdk/python/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@
"Jinja2>=2.0.0",
"jsonschema",
"mmh3",
"numpy<1.22", # 1.22 drops support for python 3.7.
"pandas>=1.0.0",
"pandavro==1.5.*",
"protobuf>=3.10,<3.20",
Expand Down
70 changes: 0 additions & 70 deletions sdk/python/tests/unit/test_feature_views.py

This file was deleted.

0 comments on commit a7437fa

Please sign in to comment.