fix: Set default values for feature_store.serve() function (#4225)

feast-dev · May 28, 2024 · fa74438 · fa74438
1 parent 6b3094e
commit fa74438
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/sdk/python/feast/cli.py b/sdk/python/feast/cli.py
@@ -680,7 +680,6 @@ def serve_command(
     port: int,
     type_: str,
     no_access_log: bool,
-    no_feature_log: bool,
     workers: int,
     keep_alive_timeout: int,
     registry_ttl_sec: int = 5,
@@ -693,7 +692,6 @@ def serve_command(
         port=port,
         type_=type_,
         no_access_log=no_access_log,
-        no_feature_log=no_feature_log,
         workers=workers,
         keep_alive_timeout=keep_alive_timeout,
         registry_ttl_sec=registry_ttl_sec,

diff --git a/sdk/python/feast/feature_store.py b/sdk/python/feast/feature_store.py
@@ -2448,12 +2448,11 @@ def serve(
         self,
         host: str,
         port: int,
-        type_: str,
-        no_access_log: bool,
-        no_feature_log: bool,
-        workers: int,
-        keep_alive_timeout: int,
-        registry_ttl_sec: int,
+        type_: str = "http",
+        no_access_log: bool = True,
+        workers: int = 1,
+        keep_alive_timeout: int = 30,
+        registry_ttl_sec: int = 2,
     ) -> None:
         """Start the feature consumption server locally on a given port."""
         type_ = type_.lower()