fix: Configuration to stop coercion of tz for entity_df (#3255)

add option to skip coercion Signed-off-by: ammarar <ammar.alrashed@gmail.com> Signed-off-by: ammarar <ammar.alrashed@gmail.com>
feast-dev · Sep 30, 2022 · fdc8d67 · fdc8d67
1 parent 55e28e2
commit fdc8d67
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/sdk/python/feast/feature_store.py b/sdk/python/feast/feature_store.py
@@ -1111,7 +1111,8 @@ def get_historical_features(
 
         # Check that the right request data is present in the entity_df
         if type(entity_df) == pd.DataFrame:
-            entity_df = utils.make_df_tzaware(cast(pd.DataFrame, entity_df))
+            if self.config.coerce_tz_aware:
+                entity_df = utils.make_df_tzaware(cast(pd.DataFrame, entity_df))
             for fv in request_feature_views:
                 for feature in fv.features:
                     if feature.name not in entity_df.columns:

diff --git a/sdk/python/feast/repo_config.py b/sdk/python/feast/repo_config.py
@@ -166,6 +166,9 @@ class RepoConfig(FeastBaseModel):
     feature values for entities that have already been written into the online store.
     """
 
+    coerce_tz_aware: Optional[bool] = True
+    """ If True, coerces entity_df timestamp columns to be timezone aware (to UTC by default). """
+
     def __init__(self, **data: Any):
         super().__init__(**data)