Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI fails to run correctly on project with offline Featureviews #2719

Closed
dvanbrug opened this issue May 19, 2022 · 1 comment · Fixed by #2766
Closed

UI fails to run correctly on project with offline Featureviews #2719

dvanbrug opened this issue May 19, 2022 · 1 comment · Fixed by #2766

Comments

@dvanbrug
Copy link
Contributor

dvanbrug commented May 19, 2022

Expected Behavior

When FeatureViews have online=False, running feast ui should start the UI and load the project.

Current Behavior

The UI fails to load with the following error:

Error Loading Project Configs
There was an error loading the Project Configurations. Please check that feature_store.yaml file is available and well-formed.

This looks like it is caused by the registry dump not containing the online key for the feature views.

Steps to reproduce

  1. Create a default repo using feast init
  2. In example.py change online=True to online=False.
  3. Run feast ui

Specifications

  • Version: 0.21.2
  • Platform: macOS
  • Subsystem:

Possible Solution

To fix this, the registry should always contain the online key for FeatureViews even if they are set to False.

Perhaps this is related to this quirk of protobufs: protocolbuffers/protobuf#1772 which would mean that the online key doesn't come through in the call to to_proto here:

self._message_to_sorted_dict(feature_view.to_proto())

@adchia
Copy link
Collaborator

adchia commented May 19, 2022

Thanks for catching!

Would you mind opening a PR for this? Think that it's also addressable with changing

https://github.com/feast-dev/feast/blob/master/ui/src/parsers/feastFeatureViews.ts#L42

to have online as optional. We probably should throw a better error message too..

dvanbrug added a commit to dvanbrug/feast that referenced this issue Jun 7, 2022
Change the `online` field in feastFeatureViews schema to be optional.
This addresses a problem with the UI erroring out when trying to present
offline FeatureViews since protobuf would not pass along the `online`
tag (feast-dev#2719).

Signed-off-by: Dirk Van Bruggen <dirk@punchcyber.com>
adchia pushed a commit that referenced this issue Jun 8, 2022
Change the `online` field in feastFeatureViews schema to be optional.
This addresses a problem with the UI erroring out when trying to present
offline FeatureViews since protobuf would not pass along the `online`
tag (#2719).

Signed-off-by: Dirk Van Bruggen <dirk@punchcyber.com>
adchia pushed a commit that referenced this issue Jun 13, 2022
Change the `online` field in feastFeatureViews schema to be optional.
This addresses a problem with the UI erroring out when trying to present
offline FeatureViews since protobuf would not pass along the `online`
tag (#2719).

Signed-off-by: Dirk Van Bruggen <dirk@punchcyber.com>
adchia pushed a commit that referenced this issue Jun 13, 2022
## [0.21.3](v0.21.2...v0.21.3) (2022-06-13)

### Bug Fixes

* Change online UI schema field to be optional ([#2766](#2766)) ([e6edb58](e6edb58)), closes [#2719](#2719)
* Made URL to registry relative, fixes [#2731](#2731) ([#2753](#2753)) ([a66aea8](a66aea8))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants