-
Notifications
You must be signed in to change notification settings - Fork 961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI fails to run correctly on project with offline Featureviews #2719
Labels
Comments
Thanks for catching! Would you mind opening a PR for this? Think that it's also addressable with changing https://github.com/feast-dev/feast/blob/master/ui/src/parsers/feastFeatureViews.ts#L42 to have |
dvanbrug
added a commit
to dvanbrug/feast
that referenced
this issue
Jun 7, 2022
Change the `online` field in feastFeatureViews schema to be optional. This addresses a problem with the UI erroring out when trying to present offline FeatureViews since protobuf would not pass along the `online` tag (feast-dev#2719). Signed-off-by: Dirk Van Bruggen <dirk@punchcyber.com>
adchia
pushed a commit
that referenced
this issue
Jun 8, 2022
Change the `online` field in feastFeatureViews schema to be optional. This addresses a problem with the UI erroring out when trying to present offline FeatureViews since protobuf would not pass along the `online` tag (#2719). Signed-off-by: Dirk Van Bruggen <dirk@punchcyber.com>
adchia
pushed a commit
that referenced
this issue
Jun 13, 2022
Change the `online` field in feastFeatureViews schema to be optional. This addresses a problem with the UI erroring out when trying to present offline FeatureViews since protobuf would not pass along the `online` tag (#2719). Signed-off-by: Dirk Van Bruggen <dirk@punchcyber.com>
adchia
pushed a commit
that referenced
this issue
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behavior
When FeatureViews have
online=False
, runningfeast ui
should start the UI and load the project.Current Behavior
The UI fails to load with the following error:
This looks like it is caused by the registry dump not containing the
online
key for the feature views.Steps to reproduce
feast init
example.py
changeonline=True
toonline=False
.feast ui
Specifications
Possible Solution
To fix this, the registry should always contain the
online
key for FeatureViews even if they are set to False.Perhaps this is related to this quirk of protobufs: protocolbuffers/protobuf#1772 which would mean that the
online
key doesn't come through in the call toto_proto
here:feast/sdk/python/feast/registry.py
Line 914 in f4eed30
The text was updated successfully, but these errors were encountered: