Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support passing in feature_store.yaml explicitly to FeatureStore #2848

Closed
achals opened this issue Jun 23, 2022 · 1 comment
Closed

Support passing in feature_store.yaml explicitly to FeatureStore #2848

achals opened this issue Jun 23, 2022 · 1 comment
Labels
Community Contribution Needed We want community to contribute good first issue Good for newcomers kind/feature New feature or request priority/p2

Comments

@achals
Copy link
Member

achals commented Jun 23, 2022

Is your feature request related to a problem? Please describe.
Right now, feast assumes that the feature_store.yaml is always located at the root of the feature repo. This is a reasonable assumption, but introduces some issues for users - when using multiple environments (e.g. staging vs production) users need to duplicate their feature definitions into multiple directories.

Describe the solution you'd like
The feast CLI should support a new flag on all commands, the explicit location of the feature_store.yaml file. Something like:

feast --config-yaml-location production/feature_store.yaml apply

Similarly, the FeatureStore class should have an additional parameter, config_yaml_location (or something like it):

class FeatureStore:
    def __init__(
        self, repo_path = None, config_yaml_location = None
    ):

        config_path = config_yaml_location or Path(repo_path) / 'feature_store.yaml'

Describe alternatives you've considered
?

@achals achals added kind/feature New feature or request good first issue Good for newcomers priority/p2 Community Contribution Needed We want community to contribute labels Jun 23, 2022
@kevjumba
Copy link
Collaborator

kevjumba commented Aug 3, 2022

This is a duplicate issue @achals from #1556

@kevjumba kevjumba closed this as completed Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Needed We want community to contribute good first issue Good for newcomers kind/feature New feature or request priority/p2
Projects
None yet
Development

No branches or pull requests

2 participants