fix: Fix feature service inference logic #3089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #3089 +/- ##
==========================================
+ Coverage 67.12% 75.86% +8.73%
==========================================
Files 173 206 +33
Lines 15110 17142 +2032
==========================================
+ Hits 10142 13004 +2862
+ Misses 4968 4138 -830
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
achals
reviewed
Aug 17, 2022
sdk/python/feast/feature_service.py
Outdated
| @@ -123,8 +123,15 @@ def infer_features(self, fvs_to_update: Optional[Dict[str, FeatureView]] = None) | |||
| if f.name in desired_features: | |||
| projection.features.append(f) | |||
| elif not projection.desired_features and projection.features: | |||
| # Second cass, so nothing needs to be done. | |||
| pass | |||
| # Second cass, so nothing needs to be done. In case something went wrong | |||
There was a problem hiding this comment.
Suggested change
| # Second cass, so nothing needs to be done. In case something went wrong | |
| # Second case, so nothing needs to be done. In case something went wrong |
adchia
reviewed
Aug 17, 2022
sdk/python/feast/feature_service.py
Outdated
| desired_features = set( | ||
| feature_grouping.projection.desired_features | ||
| ) | ||
| # There are three situations to be handled. First, the projection specifies |
There was a problem hiding this comment.
Might be easier to read if you have the cases within the blocks themselves, instead of all in one block before the if starts
sdk/python/feast/feature_service.py
Outdated
| for f in fvs_to_update[feature_grouping.name].features: | ||
| if f.name in desired_features: | ||
| feature_grouping.projection.features.append(f) | ||
| projection.features.append(f) | ||
| elif not projection.desired_features and projection.features: |
There was a problem hiding this comment.
would be cleaner imo if you had early returns instead of the elif and else.. and maybe some example definitions
e.g.
if projection.desired_features:
# The projection wants to reference inferred features. Validate they exist
# Example: FeatureService(features=[[fv_with_no_schema["feature]])
...
return
if projection.features:
# The projection only references features from a FV's known schema (not inferred).
# Example 1: FeatureService(features=[fv_with_schema[["feature"]])
# Example 2: FeatureService(features=[fv_with_schema])
return
# The projection wants all features from a FV that has an inferred schema
# Example: FeatureService(features=[fv_with_no_schema])
...
sdk/python/feast/feature_service.py
Outdated
| for f in fvs_to_update[feature_grouping.name].features: | ||
| if f.name in desired_features: | ||
| feature_grouping.projection.features.append(f) | ||
| projection.features.append(f) | ||
| elif not projection.desired_features and projection.features: |
There was a problem hiding this comment.
wondering if we can exit earlier than this. i.e in line 98 instead
adchia
reviewed
Aug 18, 2022
| if projection.features: | ||
| # The projection has already selected features from a feature view with a | ||
| # known schema, so no action needs to be taken. | ||
| # Example: FeatureService(features=[fv[["existing_feature"]]]), where |
There was a problem hiding this comment.
This also applies if the user is selecting from a fv with a known schema, but doesn't select features right?
adchia
reviewed
Aug 18, 2022
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adchia, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kevjumba
pushed a commit
that referenced
this pull request
Aug 25, 2022
# [0.24.0](v0.23.0...v0.24.0) (2022-08-25) ### Bug Fixes * Check if on_demand_feature_views is an empty list rather than None for snowflake provider ([#3046](#3046)) ([9b05e65](9b05e65)) * FeatureStore.apply applies BatchFeatureView correctly ([#3098](#3098)) ([41be511](41be511)) * Fix Feast Java inconsistency with int64 serialization vs python ([#3031](#3031)) ([4bba787](4bba787)) * Fix feature service inference logic ([#3089](#3089)) ([4310ed7](4310ed7)) * Fix field mapping logic during feature inference ([#3067](#3067)) ([cdfa761](cdfa761)) * Fix incorrect on demand feature view diffing and improve Java tests ([#3074](#3074)) ([0702310](0702310)) * Fix Java helm charts to work with refactored logic. Fix FTS image ([#3105](#3105)) ([2b493e0](2b493e0)) * Fix on demand feature view output in feast plan + Web UI crash ([#3057](#3057)) ([bfae6ac](bfae6ac)) * Fix release workflow to release 0.24.0 ([#3138](#3138)) ([a69aaae](a69aaae)) * Fix Spark offline store type conversion to arrow ([#3071](#3071)) ([b26566d](b26566d)) * Fixing Web UI, which fails for the SQL registry ([#3028](#3028)) ([64603b6](64603b6)) * Force Snowflake Session to Timezone UTC ([#3083](#3083)) ([9f221e6](9f221e6)) * Make infer dummy entity join key idempotent ([#3115](#3115)) ([1f5b1e0](1f5b1e0)) * More explicit error messages ([#2708](#2708)) ([e4d7afd](e4d7afd)) * Parse inline data sources ([#3036](#3036)) ([c7ba370](c7ba370)) * Prevent overwriting existing file during `persist` ([#3088](#3088)) ([69af21f](69af21f)) * Register BatchFeatureView in feature repos correctly ([#3092](#3092)) ([b8e39ea](b8e39ea)) * Return an empty infra object from sql registry when it doesn't exist ([#3022](#3022)) ([8ba87d1](8ba87d1)) * Teardown tables for Snowflake Materialization testing ([#3106](#3106)) ([0a0c974](0a0c974)) * UI error when saved dataset is present in registry. ([#3124](#3124)) ([83cf753](83cf753)) * Update sql.py ([#3096](#3096)) ([2646a86](2646a86)) * Updated snowflake template ([#3130](#3130)) ([f0594e1](f0594e1)) ### Features * Add authentication option for snowflake connector ([#3039](#3039)) ([74c75f1](74c75f1)) * Add Cassandra/AstraDB online store contribution ([#2873](#2873)) ([feb6cb8](feb6cb8)) * Add Snowflake materialization engine ([#2948](#2948)) ([f3b522b](f3b522b)) * Adding saved dataset capabilities for Postgres ([#3070](#3070)) ([d3253c3](d3253c3)) * Allow passing repo config path via flag ([#3077](#3077)) ([0d2d951](0d2d951)) * Contrib azure provider with synapse/mssql offline store and Azure registry store ([#3072](#3072)) ([9f7e557](9f7e557)) * Custom Docker image for Bytewax batch materialization ([#3099](#3099)) ([cdd1b07](cdd1b07)) * Feast AWS Athena offline store (again) ([#3044](#3044)) ([989ce08](989ce08)) * Implement spark offline store `offline_write_batch` method ([#3076](#3076)) ([5b0cc87](5b0cc87)) * Initial Bytewax materialization engine ([#2974](#2974)) ([55c61f9](55c61f9)) * Refactor feature server helm charts to allow passing feature_store.yaml in environment variables ([#3113](#3113)) ([85ee789](85ee789))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #3075