Accept Pandas dataframe as input for historical feature retrieval #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>
khorshuheng
requested review from
davidheryanto,
pyalex,
woop and
zhilingc
as code owners
Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>
|
/test test-end-to-end-auth |
woop
approved these changes
Oct 19, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: khorshuheng, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
pyalex
reviewed
Oct 20, 2020
| "event_timestamp", | ||
| "created_timestamp", | ||
| ParquetFormat(), | ||
| entity_staging_uri.path, |
pyalex
reviewed
Oct 20, 2020
| entity_source.to_parquet(df_export_path.name) | ||
| bucket = ( | ||
| None | ||
| if entity_staging_uri.scheme == "fs" |
There was a problem hiding this comment.
what's fs scheme? maybe file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Khor Shu Heng khor.heng@gojek.com
What this PR does / why we need it:
Currently, historical feature retrieval accepts only Datasource as input. This PR enables the user to supply a Panda dataframe instead, which will then be uploaded to a staging location.
Staging location configuration for the different spark clusters are also merged into a single key in this PR.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: