New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Feast apply to import files recursively (and add .feastignore) #1482
Conversation
Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai>
Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai>
only comment is to document this functionality, but if you want to do it in a separate diff feel free to merge |
I agree. Aside from @oavdeev's comment the only thing that is missing is documentation. Would you mind adding a page under |
…r merging with master Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai>
@woop If I understood correctly, I need to go through the documentation changes through GitBook. If so, let's merge this independently. |
Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jklegar, tsotnet, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
…1482) * feast apply should import files recursively, add .feastignore Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai> * Add assertpy to ci dependencies Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai> * Simplify reading using Path.read_text() and update the test file after merging with master Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai> * Add documentation Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai>
Signed-off-by: Tsotne Tabidze tsotne@tecton.ai
What this PR does / why we need it: We add functionality to
feast apply
to recursively look into the feature repo and import all files to find Feast Objects for apply. Also, we add.feastignore
file where users can define which paths to ignore (similar to.gitignore
). This format can understand comments (with #) and matches (* and **).Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: