Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Feast apply to import files recursively (and add .feastignore) #1482

Merged
merged 6 commits into from Apr 27, 2021

Conversation

tsotnet
Copy link
Collaborator

@tsotnet tsotnet commented Apr 20, 2021

Signed-off-by: Tsotne Tabidze tsotne@tecton.ai

What this PR does / why we need it: We add functionality to feast apply to recursively look into the feature repo and import all files to find Feast Objects for apply. Also, we add .feastignore file where users can define which paths to ignore (similar to .gitignore). This format can understand comments (with #) and matches (* and **).

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

* `feast apply` will recursively parse files in feature repo sub directories
* `.feastignore` will allow defining paths to ignore during `feast apply`, similarly to `.gitignore`

Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai>
Tsotne Tabidze added 2 commits April 19, 2021 19:11
@tsotnet tsotnet removed the request for review from oavdeev April 20, 2021 17:16
@jklegar
Copy link
Collaborator

jklegar commented Apr 21, 2021

only comment is to document this functionality, but if you want to do it in a separate diff feel free to merge

@woop woop changed the title feast apply should import files recursively, add .feastignore Allow Feast apply to import files recursively (and add .feastignore) Apr 22, 2021
@woop
Copy link
Member

woop commented Apr 22, 2021

only comment is to document this functionality, but if you want to do it in a separate diff feel free to merge

I agree. Aside from @oavdeev's comment the only thing that is missing is documentation. Would you mind adding a page under Reference in our documentation to describe the functionality of .feastignore? We should probably also mention the .feastignore in the Feature Repository section.

Tsotne Tabidze added 2 commits April 24, 2021 13:43
@tsotnet
Copy link
Collaborator Author

tsotnet commented Apr 25, 2021

@woop If I understood correctly, I need to go through the documentation changes through GitBook. If so, let's merge this independently.

Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai>
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jklegar, tsotnet, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jklegar,tsotnet,woop]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member

woop commented Apr 27, 2021

/lgtm

@feast-ci-bot feast-ci-bot merged commit 786dde7 into feast-dev:master Apr 27, 2021
woop pushed a commit that referenced this pull request Apr 27, 2021
…1482)

* feast apply should import files recursively, add .feastignore

Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai>

* Add assertpy to ci dependencies

Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai>

* Simplify reading using Path.read_text() and update the test file after merging with master

Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai>

* Add documentation

Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants