-
Notifications
You must be signed in to change notification settings - Fork 966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump supported Python version to 3.7 #1504
Conversation
Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai>
/test test-telemetry |
@tsotnet: The
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tsotnet, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai>
Are there other reasons besides the issue described in #1502 that makes us no longer want to support Python 3.6? We are currently running Python 3.6 (with Feast 0.8) and it seems to me could work around the issue described quite easily by casting the Did a quick test run and the following works on Python 3.6 for class LocalProvider(Provider):
_db_path: Path
def __init__(self, config: RepoConfig, repo_path: Path):
...
if local_path.is_absolute():
self._db_path = str(local_path)
else:
self._db_path = str(repo_path.joinpath(local_path))
self.offline_store = get_offline_store_from_config(config.offline_store)
... |
Just an FYI; the rationale was provided here: #1503 (comment) |
Thanks @chappers for pointing that out. |
Signed-off-by: Tsotne Tabidze tsotne@tecton.ai
What this PR does / why we need it: Currently, setup.py incorrectly supports Python 3.6. Bumping the version to 3.7.
Which issue(s) this PR fixes:
Fixes #1502
Does this PR introduce a user-facing change?: