-
Notifications
You must be signed in to change notification settings - Fork 966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ttl duration when ttl is None #1624
Conversation
Hi @MattDelac. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
fe276dd
to
79b4311
Compare
/kind bug |
Codecov Report
@@ Coverage Diff @@
## master #1624 +/- ##
==========================================
- Coverage 83.64% 83.55% -0.09%
==========================================
Files 67 67
Lines 5814 5815 +1
==========================================
- Hits 4863 4859 -4
- Misses 951 956 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MattDelac, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Rerunning the tests now. Codecov has a bug that I tried to fix. You may need to rebase on master. 3b22005 |
Will do |
79b4311
to
ef63996
Compare
That did not help for now |
I think we have to wait for it to be resolved here: codecov/codecov-action#330 For the time being I will turn off failure in CI |
Signed-off-by: Matt Delacour <matt.delacour@shopify.com>
ef63996
to
e7ff05e
Compare
/lgtm |
What this PR does / why we need it:
![image](https://user-images.githubusercontent.com/18557047/121019457-7304f700-c76d-11eb-814e-38aa5da8695c.png)
Fix
ttl_duration
when TTL is NoneWhich issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:
NONE