-
Notifications
You must be signed in to change notification settings - Fork 966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't use .result() in BigQueryOfflineStore, since it still leads to OOM #1642
Don't use .result() in BigQueryOfflineStore, since it still leads to OOM #1642
Conversation
Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai>
Codecov Report
@@ Coverage Diff @@
## master #1642 +/- ##
==========================================
- Coverage 83.60% 83.40% -0.21%
==========================================
Files 67 67
Lines 6027 6026 -1
==========================================
- Hits 5039 5026 -13
- Misses 988 1000 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai>
Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tsotnet, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…OOM (#1642) * Don't use .result() at all, since it still leads to OOM Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai> * Lint Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai> * Create a temp table, since anon query doesn't work for large tables Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai> * Fix linter Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai>
Signed-off-by: Tsotne Tabidze tsotne@tecton.ai
What this PR does / why we need it: Follow up on #1638, which failed to fix the OOM issue.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: