Don't use .result() in BigQueryOfflineStore, since it still leads to OOM #1642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai>
Codecov Report
@@ Coverage Diff @@
## master #1642 +/- ##
==========================================
- Coverage 83.60% 83.40% -0.21%
==========================================
Files 67 67
Lines 6027 6026 -1
==========================================
- Hits 5039 5026 -13
- Misses 988 1000 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
woop
requested changes
Jun 11, 2021
Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai>
Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai>
|
/lgtm |
woop
approved these changes
Jun 11, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tsotnet, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tsotnet
pushed a commit
that referenced
this pull request
Jun 17, 2021
…OOM (#1642) * Don't use .result() at all, since it still leads to OOM Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai> * Lint Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai> * Create a temp table, since anon query doesn't work for large tables Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai> * Fix linter Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tsotne Tabidze tsotne@tecton.ai
What this PR does / why we need it: Follow up on #1638, which failed to fix the OOM issue.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: