Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reducing size of universal repo to decrease integration test time #1826

Merged
merged 1 commit into from Sep 2, 2021

Conversation

adchia
Copy link
Collaborator

@adchia adchia commented Sep 1, 2021

What this PR does / why we need it:
Reducing the size of the universal repo datasets, shaving 45 seconds off of integration tests (down from 6 minutes)

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

…to 5:15

Signed-off-by: Danny Chiao <danny@tecton.ai>
@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2021

Codecov Report

Merging #1826 (e95cc9d) into master (66cf6a4) will decrease coverage by 20.85%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1826       +/-   ##
===========================================
- Coverage   84.64%   63.79%   -20.86%     
===========================================
  Files          93       93               
  Lines        6812     6811        -1     
===========================================
- Hits         5766     4345     -1421     
- Misses       1046     2466     +1420     
Flag Coverage Δ
integrationtests ?
unittests 63.79% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ts/integration/feature_repos/repo_configuration.py 60.29% <0.00%> (-39.71%) ⬇️
.../integration/online_store/test_online_retrieval.py 17.39% <0.00%> (-82.61%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 18.18% <0.00%> (-81.82%) ⬇️
.../integration/online_store/test_universal_online.py 18.96% <0.00%> (-81.04%) ⬇️
...fline_store/test_universal_historical_retrieval.py 22.09% <0.00%> (-77.91%) ⬇️
...gration/registration/test_feature_service_apply.py 31.25% <0.00%> (-68.75%) ⬇️
...hon/tests/integration/registration/test_cli_gcp.py 31.70% <0.00%> (-68.30%) ⬇️
...s/integration/registration/test_universal_types.py 31.95% <0.00%> (-68.05%) ⬇️
...n/tests/integration/registration/test_cli_redis.py 32.55% <0.00%> (-67.45%) ⬇️
sdk/python/feast/infra/online_stores/redis.py 30.35% <0.00%> (-64.29%) ⬇️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66cf6a4...e95cc9d. Read the comment docs.

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 021daf0 into feast-dev:master Sep 2, 2021
@adchia adchia deleted the smallertests branch September 2, 2021 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants