-
Notifications
You must be signed in to change notification settings - Fork 966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide FeatureViewProjections from user interface & have FeatureViews carry FVProjections that carries the modified info of the FeatureView #1899
Conversation
Signed-off-by: David Y Liu <davidyliuliu@gmail.com>
Signed-off-by: David Y Liu <davidyliuliu@gmail.com>
Signed-off-by: David Y Liu <davidyliuliu@gmail.com>
Hi @mavysavydav. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Cody Lin <codyl@twitter.com>
Codecov Report
@@ Coverage Diff @@
## master #1899 +/- ##
===========================================
- Coverage 82.95% 60.13% -22.83%
===========================================
Files 96 96
Lines 7359 7490 +131
===========================================
- Hits 6105 4504 -1601
- Misses 1254 2986 +1732
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Cody Lin <codyl@twitter.com>
c4a042c
to
e69ad89
Compare
/retest |
Signed-off-by: David Y Liu <davidyliuliu@gmail.com>
What happened to setup.py? |
Signed-off-by: David Y Liu <davidyliuliu@gmail.com>
a5aab1a
to
67c7d47
Compare
Signed-off-by: David Y Liu <davidyliuliu@gmail.com>
4f810d8
to
292f9de
Compare
e2c3a53
to
bad7e63
Compare
Signed-off-by: David Y Liu <davidyliuliu@gmail.com>
bad7e63
to
659374a
Compare
tags=dict(feature_service_proto.spec.tags), | ||
description=( | ||
feature_service_proto.spec.description | ||
if feature_service_proto.spec.description != "" | ||
else None | ||
), | ||
) | ||
fs.feature_view_projections.extend( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious why you moved this code out of the constructor. Don't feel strongly about it though.
sdk/python/feast/feature_view.py
Outdated
|
||
def set_projection(self, feature_view_projection: FeatureViewProjection) -> None: | ||
""" | ||
Setter for the projection object held by this FeatureView. Performs checks to ensure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: These comments assume the user knows exactly what a projection is. I think it's important to define what a projection is.
abc655b
to
ef0d75c
Compare
Signed-off-by: David Y Liu <davidyliuliu@gmail.com>
ef0d75c
to
31cd6a8
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, mavysavydav, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
DEPENDENT ON - #1899
What this PR does / why we need it: #1907
Which issue(s) this PR fixes: #1907
Fixes #1907
Does this PR introduce a user-facing change?: