Add location to BigQueryOfflineStoreConfig #1921
Conversation
Signed-off-by: Kevin Loftis <loftiskg@gmail.com>
loftiskg
requested review from
achals,
adchia,
felixwang9817,
tsotnet,
woop and
a team
as code owners
|
Hi @loftiskg. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #1921 +/- ##
==========================================
+ Coverage 82.97% 82.98% +0.01%
==========================================
Files 96 96
Lines 7376 7377 +1
==========================================
+ Hits 6120 6122 +2
+ Misses 1256 1255 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| @@ -52,6 +52,9 @@ class BigQueryOfflineStoreConfig(FeastConfigBaseModel): | |||
| project_id: Optional[StrictStr] = None | |||
| """ (optional) GCP project name used for the BigQuery offline store """ | |||
|
|
|||
| location: Optional[StrictStr] = None | |||
| """ (optional) GCP location name used for the BigQuery offline store """ | |||
There was a problem hiding this comment.
I think it would be really useful to provide an example as part of this comment, like US or EU
There was a problem hiding this comment.
Good call. Added some additional documentation.
|
Thanks for this PR @loftiskg! |
|
Just left a small nitpick comment on the config comment, but otherwise it's good to merge. |
Signed-off-by: Kevin Loftis <loftiskg@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: loftiskg, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
What this PR does / why we need it:
Currently, the BigQueryOfflineStore default to the 'us' GCP region and does provide a configuration to change the region. This PR adds a config to BigQueryOfflineStoreConfig that allows defining a GCP region for a BigQueryOfflineStore.
The default behavior (defaulting to region 'us') is maintained (ie. no location/region specified in the offline store configuration).
Which issue(s) this PR fixes:
Fixes #1728
Does this PR introduce a user-facing change?: