Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in feast alpha enable CLI command #1940

Merged
merged 2 commits into from
Oct 14, 2021

Conversation

felixwang9817
Copy link
Collaborator

Signed-off-by: Felix Wang wangfelix98@gmail.com

What this PR does / why we need it: Previously, feast alpha enable could modify the feature_store.yaml file in a breaking way; this PR prevents that from happening. Note that non-breaking, but potentially unexpected modifications, are still possible. For example, calling feast alpha enable python_feature_server on the following feature_store.yaml

registry: data/registry.db
project: smooth_fish
provider: local
online_store:
  type: redis
flags:
  alpha_features: true
  python_feature_server: true

will still change it to

registry: data/registry.db
project: smooth_fish
provider: local
online_store:
  type: redis
offline_store:
  type: file
flags:
  alpha_features: true
  python_feature_server: true

Which issue(s) this PR fixes:

Fixes #1938

Does this PR introduce a user-facing change?:

The feast alpha enable CLI command is now fixed

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@felixwang9817
Copy link
Collaborator Author

/kind bug

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2021

Codecov Report

Merging #1940 (65abaa9) into master (e8a1519) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1940   +/-   ##
=======================================
  Coverage   82.26%   82.26%           
=======================================
  Files          96       96           
  Lines        7669     7669           
=======================================
  Hits         6309     6309           
  Misses       1360     1360           
Flag Coverage Δ
integrationtests 74.15% <ø> (ø)
unittests 59.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/repo_config.py 78.97% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8a1519...65abaa9. Read the comment docs.

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 973f1c5 into feast-dev:master Oct 14, 2021
@felixwang9817 felixwang9817 deleted the fix_feast_alpha_enable branch October 14, 2021 06:38
felixwang9817 added a commit that referenced this pull request Oct 28, 2021
* Fix bug in feast alpha enable CLI command

Signed-off-by: Felix Wang <wangfelix98@gmail.com>

* Lint

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feast alpha enable command messes up feature_store.yaml
5 participants