-
Notifications
You must be signed in to change notification settings - Fork 966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in feast alpha enable CLI command #1940
Fix bug in feast alpha enable CLI command #1940
Conversation
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
/kind bug |
Codecov Report
@@ Coverage Diff @@
## master #1940 +/- ##
=======================================
Coverage 82.26% 82.26%
=======================================
Files 96 96
Lines 7669 7669
=======================================
Hits 6309 6309
Misses 1360 1360
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Fix bug in feast alpha enable CLI command Signed-off-by: Felix Wang <wangfelix98@gmail.com> * Lint Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang wangfelix98@gmail.com
What this PR does / why we need it: Previously,
feast alpha enable
could modify thefeature_store.yaml
file in a breaking way; this PR prevents that from happening. Note that non-breaking, but potentially unexpected modifications, are still possible. For example, callingfeast alpha enable python_feature_server
on the followingfeature_store.yaml
will still change it to
Which issue(s) this PR fixes:
Fixes #1938
Does this PR introduce a user-facing change?: