-
Notifications
You must be signed in to change notification settings - Fork 966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move IntegrationTestRepoConfig class to another module #1962
Conversation
/kind bug |
Codecov Report
@@ Coverage Diff @@
## master #1962 +/- ##
==========================================
- Coverage 81.97% 74.31% -7.67%
==========================================
Files 99 98 -1
Lines 7922 7867 -55
==========================================
- Hits 6494 5846 -648
- Misses 1428 2021 +593
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
77c876e
to
b43ccef
Compare
b43ccef
to
8f6df52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adchia, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Felix Wang wangfelix98@gmail.com
What this PR does / why we need it: In order for plugin repos to override
FULL_REPO_CONFIGS
, they must import theIntegrationTestRepoConfig
class. However, if the class remains inrepo_configuration.py
, it will automatically triggerFULL_REPO_CONFIGS
to be computed. By moving the class to another file, we avoid this circular logic.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: