-
Notifications
You must be signed in to change notification settings - Fork 966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues with lint test and upgrade pip version #1964
Conversation
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1964 +/- ##
=======================================
Coverage 81.97% 81.97%
=======================================
Files 99 99
Lines 7922 7922
=======================================
Hits 6494 6494
Misses 1428 1428
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/kind bug |
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, adchia, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to merge this pr inspire of failing builds because the pr is meant to fix the builds, but won't reflect in the pr_integration_tests github actions because of it using pull_request_target.
Signed-off-by: Felix Wang wangfelix98@gmail.com
What this PR does / why we need it: This PR fixes the issues with the lint test. Specifically, it seems like this was the issue. It also upgrades the
pip
version to be>=21.3.1
.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: