Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix protobuf version conflict in [gcp] and [ci] packages #1992

Merged

Conversation

ysk24ok
Copy link
Contributor

@ysk24ok ysk24ok commented Nov 3, 2021

Signed-off-by: Yusuke Nishioka yusuke.nishioka.0713@gmail.com

What this PR does / why we need it:

proto-plus==1.19.7 requires protobuf>=3.19.0, which conflicts with the version required by google-api-core[grpc].
Also, setup_requires tries to install the latest version of mypy-protobuf because the version is not specified and it requires protobuf>=3.18.0.
The error log is like this:

$ pipenv install -e "sdk/python[gcp]"
...
There are incompatible versions in the resolved dependencies:
  protobuf>=3.10 (from -r /tmp/pipenvu4bjkllirequirements/pipenv-sxv104g1-constraints.txt (line 21))
  protobuf<3.18.0,>=3.12.0 (from google-api-core[grpc]==1.31.3->-r /tmp/pipenvu4bjkllirequirements/pipenv-sxv104g1-constraints.txt (line 5))
  protobuf<4.0dev,>=3.5.0.post1 (from grpcio-tools==1.34.0->-r /tmp/pipenvu4bjkllirequirements/pipenv-sxv104g1-constraints.txt (line 13))
  protobuf>=3.12.0 (from google-cloud-bigquery==2.29.0->-r /tmp/pipenvu4bjkllirequirements/pipenv-sxv104g1-constraints.txt (line 26))
  protobuf>=3.18.0 (from mypy-protobuf==3.0.0->-r /tmp/pipenvu4bjkllirequirements/pipenv-sxv104g1-constraints.txt (line 3))
  protobuf>=3.19.0 (from proto-plus==1.19.7->google-cloud-bigquery==2.29.0->-r /tmp/pipenvu4bjkllirequirements/pipenv-sxv104g1-constraints.txt (line 26))
  protobuf>=3.6.0 (from googleapis-common-protos==1.52.0->-r /tmp/pipenvu4bjkllirequirements/pipenv-sxv104g1-constraints.txt (line 25))
  protobuf>=3.6.0 (from grpcio-reflection==1.41.1->-r /tmp/pipenvu4bjkllirequirements/pipenv-sxv104g1-constraints.txt (line 14))

So I've fixed proto-plus version to <1.19.7 in [gcp] and [ci] packages, and mypy-protobuf in setup_requires to ==1.*.

We can check the installation succeeds by pipenv install -e "sdk/python[gcp]" and pipenv install -e "sdk/python[ci]"

Which issue(s) this PR fixes:

refs #1912 (comment)

IMO, closing #1912 should be done after the new version is released and we confirms that the installation succeeds.

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Yusuke Nishioka <yusuke.nishioka.0713@gmail.com>
@feast-ci-bot
Copy link
Collaborator

Hi @ysk24ok. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2021

Codecov Report

Merging #1992 (049999e) into master (bc4ffa5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1992   +/-   ##
=======================================
  Coverage   82.15%   82.15%           
=======================================
  Files         101      101           
  Lines        8074     8074           
=======================================
  Hits         6633     6633           
  Misses       1441     1441           
Flag Coverage Δ
integrationtests 74.62% <ø> (ø)
unittests 58.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc4ffa5...049999e. Read the comment docs.

Copy link
Collaborator

@MattDelac MattDelac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that those are already the versions we install today
image

@@ -66,6 +66,9 @@
]

GCP_REQUIRED = [
# proto-plus>=1.19.7 requires protobuf>=3.19.0
# which conflicts with the version required by google-api-core[grpc]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While those comments are really useful in the PR, it should be removed in the code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted by 42d6f6f.

Signed-off-by: Yusuke Nishioka <yusuke.nishioka.0713@gmail.com>
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MattDelac, ysk24ok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 1cbfa22 into feast-dev:master Nov 3, 2021
@ysk24ok ysk24ok deleted the fix_protobuf_version_conflict branch November 4, 2021 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants