Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Feast installation doc #207

Merged
merged 20 commits into from May 30, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
60fd94b
Update start command in Docker image
davidheryanto May 29, 2019
3a4a186
Update default values.yaml, secret config and resource request
davidheryanto May 29, 2019
85df828
Update feast installation quickstart doc
davidheryanto May 29, 2019
16936ae
Add comment to FEAST_POSTGRES_PASSWORD variable
davidheryanto May 29, 2019
6d896ae
Add comment for FEAST_STAGING_LOCATION_GCS_URI
davidheryanto May 29, 2019
b7b18bb
Make comment clearer for setting core and serving uri
davidheryanto May 29, 2019
6b1cfb4
Add missing syntax declaration for code block
davidheryanto May 29, 2019
983e182
Make comment clearer when setting core,serving uri
davidheryanto May 29, 2019
b6776dd
Update comment for 'feast config set'
davidheryanto May 29, 2019
464805f
Fix case
davidheryanto May 29, 2019
f8db50c
Make comment clearer when setting uri
davidheryanto May 29, 2019
1b54cb3
Fix core-deploy.yaml
davidheryanto May 29, 2019
615e6b9
Fix typo
davidheryanto May 29, 2019
c83e3e1
Update description of feast usage of gcp services
davidheryanto May 29, 2019
b8f7232
Update description for setting variables
davidheryanto May 29, 2019
5cc31ea
Fix gcloud container create arguments
davidheryanto May 29, 2019
126bbc1
Update required roles for feast admin and nat router requirement
davidheryanto May 29, 2019
add08af
Update GCP_REGION options
davidheryanto May 30, 2019
cd65684
Set default value for core.jobs.runner to DirectRunner in helm chart
davidheryanto May 30, 2019
b0da097
Merge branch 'master' into installation-doc
davidheryanto May 30, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfiles/core/Dockerfile
Expand Up @@ -10,7 +10,7 @@ ARG REVISION=dev
COPY --from=builder /build/core/target/feast-core-$REVISION.jar /usr/share/feast/feast-core.jar
COPY --from=builder /build/ingestion/target/feast-ingestion-$REVISION.jar /usr/share/feast/feast-ingestion.jar
ENV JOB_EXECUTABLE=/usr/share/feast/feast-ingestion.jar
ENTRYPOINT ["/usr/bin/java", \
ENTRYPOINT ["java", \
"-XX:+UnlockExperimentalVMOptions", \
"-XX:+UseCGroupMemoryLimitForHeap", \
"-jar", "/usr/share/feast/feast-core.jar"]
2 changes: 1 addition & 1 deletion Dockerfiles/serving/Dockerfile
Expand Up @@ -8,7 +8,7 @@ RUN mvn --projects serving -Drevision=$REVISION -DskipTests=true --batch-mode pa
FROM openjdk:8-jre-alpine as production
ARG REVISION=dev
COPY --from=builder /build/serving/target/feast-serving-$REVISION.jar /usr/share/feast/feast-serving.jar
ENTRYPOINT ["/usr/bin/java", \
ENTRYPOINT ["java", \
"-XX:+UseG1GC", \
"-XX:+UseStringDeduplication", \
"-XX:+UnlockExperimentalVMOptions", \
Expand Down
7 changes: 0 additions & 7 deletions charts/feast/templates/_helpers.tpl
Expand Up @@ -64,13 +64,6 @@ If release name contains chart name it will be used as a full name.
{{- end -}}
{{- end -}}

{{/*
Generate postgresql secret name
*/}}
{{- define "postgresql.secretName" -}}
{{ default (include "postgresql.fullname" .) .Values.existingSecret }}
{{- end -}}

{{/*
Create chart name and version as used by the chart label.
*/}}
Expand Down
9 changes: 7 additions & 2 deletions charts/feast/templates/core-deploy.yaml
@@ -1,4 +1,4 @@
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: {{ template "feast.core.name" . }}
Expand All @@ -11,6 +11,11 @@ metadata:
heritage: {{ .Release.Service }}
spec:
replicas: {{ .Values.core.replicaCount }}
selector:
matchLabels:
app: {{ template "feast.name" . }}
component: core
release: {{ .Release.Name }}
strategy:
type: RollingUpdate
rollingUpdate:
Expand Down Expand Up @@ -75,7 +80,7 @@ spec:
- name: DB_PASSWORD
valueFrom:
secretKeyRef:
name: {{ template "postgresql.fullname" . }}
name: {{ template "postgresql.secretName" . }}
key: postgresql-password
- name: LOG_TYPE
value: {{ .Values.core.logType }}
Expand Down
11 changes: 8 additions & 3 deletions charts/feast/templates/serving-deploy.yaml
@@ -1,4 +1,4 @@
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: {{ template "feast.serving.name" . }}
Expand All @@ -11,6 +11,11 @@ metadata:
heritage: {{ .Release.Service }}
spec:
replicas: {{ .Values.serving.replicaCount }}
selector:
matchLabels:
app: {{ template "feast.name" . }}
component: serving
release: {{ .Release.Name }}
strategy:
type: RollingUpdate
rollingUpdate:
Expand Down Expand Up @@ -72,7 +77,7 @@ spec:
- name: STORE_SERVING_TYPE
value: {{ .Values.store.serving.type }}
- name: STORE_SERVING_OPTIONS
value: {{ .Values.store.serving.options | toJson}}
value: {{ .Values.store.serving.options | toJson }}
- name: FEAST_MAX_NB_THREAD
value: "{{ .Values.serving.config.maxNumberOfThread }}"
- name: FEAST_MAX_ENTITY_PER_BATCH
Expand All @@ -84,7 +89,7 @@ spec:
- name: FEAST_REDIS_POOL_MAX_IDLE
value: "{{ .Values.serving.config.redisPool.maxIdle }}"
- name: STATSD_HOST
value: {{ .Values.statsd.host }}
value: "{{ .Values.statsd.host }}"
- name: STATSD_PORT
value: "{{ .Values.statsd.port }}"
{{- if .Values.serving.jaeger.enabled }}
Expand Down
52 changes: 29 additions & 23 deletions charts/feast/values.yaml
Expand Up @@ -10,10 +10,10 @@ core:
resources:
limits:
cpu: 4
memory: 8G
memory: 6G
requests:
cpu: 2
memory: 4G
cpu: 1
memory: 2G
rollingUpdate:
maxSurge: 2
maxUnavailable: 0
Expand All @@ -30,6 +30,7 @@ core:
# loadBalancerSourceRanges: ["10.0.0.0/8"]
jobs:
workspace: "/tmp"
# runner specifies the Beam pipeline runner, use either DirectRunner (for development) or DataflowRunner (for production)
runner: DirectRunner
options: "{}"
errorStoreType: "stdout"
Expand All @@ -46,25 +47,30 @@ core:
initialDelaySeconds: 60
failureThreshold: 1

#store:
# errors:
# type: "stdout"
# warehouse:
# type: "bigquery"
# options: '{"project": "gcp-project-id", "dataset": "feast"}'
# serving:
# type: "redis"
# options: '{"host": "...", "port": "6379"}'
# dataflow configuration is required when core.jobs.runner=DataflowRunner
# dataflow:
# projectID: ${GCP_PROJECT}
# location: ${GCP_REGION}

# postgresql:
# provision: true
# persistence:
# enabled: false
store:
errors:
type: "stdout"
warehouse:
type: "bigquery"
# options: '{"project": "gcp-project-id", "dataset": "feast"}'
serving:
type: "redis"
# options: '{"host": "redis-master", "port": "6379"}'

postgresql:
provision: true
persistence:
enabled: true

# redis:
# provision: true
# cluster:
# enabled: false
redis:
provision: false
cluster:
enabled: false

serving:
config:
Expand All @@ -86,7 +92,7 @@ serving:
memory: 4G
requests:
cpu: 1
memory: 2G
memory: 1G
rollingUpdate:
maxSurge: 2
maxUnavailable: 0
Expand All @@ -107,14 +113,14 @@ serving:
initialDelaySeconds: 120
failureThreshold: 3
readinessProbe:
initialDelaySeconds: 60
initialDelaySeconds: 30
failureThreshold: 1

# Enable only if you have an existing service account you
# want to mount the secret of.
# serviceAccount:
# name: feast-service-account
# key: feast-service-account-key
# key: service-account.json

statsd:
host: "localhost"
Expand Down