Don't materialize FeatureViews where online is False

[judahrand]

Signed-off-by: Judah Rand 17158624+judahrand@users.noreply.github.com

What this PR does / why we need it:
Currently, even if online=False is set on a FeatureView feast materialize will try to materialize the FeatureView.

This PR prevents this.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Correct behavior of non-online FeatureViews.

[feast-ci-bot]

Hi @judahrand. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov-commenter]

Codecov Report

Merging #2101 (6be6b11) into master (fc9b767) will decrease coverage by 0.02%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #2101      +/-   ##
==========================================
- Coverage   83.53%   83.51%   -0.03%     
==========================================
  Files         100      100              
  Lines        8079     8085       +6     
==========================================
+ Hits         6749     6752       +3     
- Misses       1330     1333       +3     

Flag	Coverage Δ
integrationtests	73.93% <50.00%> (-0.04%)	⬇️
unittests	58.00% <33.33%> (-0.04%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
sdk/python/feast/feature_store.py	89.96% <66.66%> (-0.27%)	⬇️
sdk/python/feast/infra/utils/aws_utils.py	84.78% <0.00%> (-0.73%)	⬇️
sdk/python/feast/infra/offline_stores/file.py	96.80% <0.00%> (ø)
sdk/python/feast/infra/offline_stores/bigquery.py	81.39% <0.00%> (ø)
sdk/python/feast/infra/offline_stores/redshift.py	86.99% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc9b767...6be6b11. Read the comment docs.

[achals]

Thanks for the contribution @judahrand ! Good catch.

[achals]

/lgtm

[feast-ci-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, judahrand, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [achals]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment