Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove argument feature_refs #2115

Merged
merged 1 commit into from Dec 8, 2021
Merged

Conversation

judahrand
Copy link
Member

What this PR does / why we need it:
This argument was scheduled for removal in 0.14 according the
deprecation warning.

Signed-off-by: Judah Rand 17158624+judahrand@users.noreply.github.com

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Remove `feature_refs` argument from `get_historical_features` and `get_online_features`.

This argument was scheduled for removal in 0.14 according the
deprecation warning.

Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
@judahrand judahrand requested a review from a team as a code owner December 7, 2021 11:38
@judahrand judahrand requested review from adchia and removed request for a team December 7, 2021 11:38
@feast-ci-bot
Copy link
Collaborator

Hi @judahrand. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2021

Codecov Report

Merging #2115 (3c9bc9e) into master (5d9e5f7) will increase coverage by 25.54%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2115       +/-   ##
===========================================
+ Coverage   57.99%   83.54%   +25.54%     
===========================================
  Files         100      100               
  Lines        8088     8084        -4     
===========================================
+ Hits         4691     6754     +2063     
+ Misses       3397     1330     -2067     
Flag Coverage Δ
integrationtests 73.96% <100.00%> (?)
unittests 58.00% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/feature_store.py 90.26% <100.00%> (+20.19%) ⬆️
sdk/python/feast/data_source.py 61.29% <0.00%> (+0.40%) ⬆️
sdk/python/feast/online_response.py 87.71% <0.00%> (+1.75%) ⬆️
sdk/python/feast/infra/online_stores/sqlite.py 96.77% <0.00%> (+2.15%) ⬆️
sdk/python/feast/feature.py 72.72% <0.00%> (+3.03%) ⬆️
sdk/python/feast/errors.py 70.00% <0.00%> (+5.00%) ⬆️
sdk/python/feast/infra/provider.py 90.74% <0.00%> (+5.55%) ⬆️
sdk/python/feast/infra/offline_stores/file.py 96.80% <0.00%> (+8.00%) ⬆️
sdk/python/feast/infra/passthrough_provider.py 100.00% <0.00%> (+10.76%) ⬆️
sdk/python/feast/repo_config.py 87.00% <0.00%> (+11.86%) ⬆️
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d9e5f7...3c9bc9e. Read the comment docs.

@judahrand
Copy link
Member Author

AWS API failures.

Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, judahrand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit cd4af4a into feast-dev:master Dec 8, 2021
adchia pushed a commit that referenced this pull request Dec 11, 2021
This argument was scheduled for removal in 0.14 according the
deprecation warning.

Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants