fix: Fix DataSource constructor to unbreak custom data sources

[achals]

What this PR does / why we need it:

As reported in slack, there's strange behavior when using feast-hive on feast 0.19. To summarize, this is incorrect in 0.19:

print(store.get_feature_view('sample_feasture'))   
"batchSource": {
      "type": "CUSTOM_SOURCE",
      "eventTimestampColumn": "created_timestamp",
      "customOptions": {

when sdk v0.17 is set it gets correct output.

"batchSource": {
      "type": "CUSTOM_SOURCE",
      "eventTimestampColumn": "event_timestamp",
      "createdTimestampColumn": "created_timestamp",
      "customOptions": {

This is because name was added a positional arg before other args here, but subclasses of DataSource may be passing params to the super constructor positionally. e.g:

https://github.com/baineng/feast-hive/blob/main/feast_hive/hive_source.py#L94

class HiveSource(DataSource):
    def __init__(
        self,
        table: Optional[str] = None,
        query: Optional[str] = None,
        event_timestamp_column: Optional[str] = "",
        created_timestamp_column: Optional[str] = "",
        field_mapping: Optional[Dict[str, str]] = None,
        date_partition_column: Optional[str] = "",
    ):
        assert (
            table is not None or query is not None
        ), '"table" or "query" is required for HiveSource.'

        super().__init__(
            event_timestamp_column,
            created_timestamp_column,
            field_mapping,
            date_partition_column,
        )

This means that all the values would be offset, breaking custom sources. This change removes name as the first positional arg, and makes it a kwarg with defaults.

I'd like to enforce only kwargs for the DataSource constructor, but this may break users again and should happen with a deprecation warning.

Thanks to Vato Kvantaliani for the pointer that something was broken here.

Which issue(s) this PR fixes:

Fixes #

[feast-ci-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [achals]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pyalex]

/lgtm

[codecov-commenter]

Codecov Report

Merging #2492 (392dc80) into master (ce35835) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2492      +/-   ##
==========================================
- Coverage   84.63%   84.54%   -0.09%     
==========================================
  Files         130      130              
  Lines       10998    11015      +17     
==========================================
+ Hits         9308     9313       +5     
- Misses       1690     1702      +12     

Flag	Coverage Δ
integrationtests	74.61% <83.33%> (-0.33%)	⬇️
unittests	58.88% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...thon/feast/infra/offline_stores/bigquery_source.py	86.32% <ø> (ø)
...thon/feast/infra/offline_stores/redshift_source.py	87.40% <ø> (ø)
...hon/feast/infra/offline_stores/snowflake_source.py	88.05% <ø> (-0.65%)	⬇️
sdk/python/feast/data_source.py	68.30% <100.00%> (+0.43%)	⬆️
sdk/python/feast/wait.py	58.82% <0.00%> (-35.30%)	⬇️
...ython/feast/embedded_go/online_features_service.py	95.08% <0.00%> (-1.64%)	⬇️
.../integration/online_store/test_universal_online.py	92.85% <0.00%> (-0.58%)	⬇️
sdk/python/feast/infra/offline_stores/snowflake.py	91.01% <0.00%> (-0.37%)	⬇️
.../feature_repos/universal/data_sources/snowflake.py	100.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce35835...392dc80. Read the comment docs.