chore: Widen dependencies #2928
Conversation
chhabrakadabra
force-pushed
the
widen-dependencies
branch
from
a7870b4
to
7abd79e
Compare
Codecov Report
@@ Coverage Diff @@
## master #2928 +/- ##
==========================================
- Coverage 78.66% 77.64% -1.02%
==========================================
Files 184 184
Lines 16313 16313
==========================================
- Hits 12833 12667 -166
- Misses 3480 3646 +166
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| "flake8", | ||
| "black==19.10b0", | ||
| "black>=22.6.0,<23", |
There was a problem hiding this comment.
Is this what caused all the formatting changes?
There was a problem hiding this comment.
Yeah. I added this in the "Additional notes" section in the PR description. Essentially, the older version of black is not compatible with the newer version of click.
chhabrakadabra
force-pushed
the
widen-dependencies
branch
from
dd0ce3b
to
4b10b8c
Compare
kevjumba
force-pushed
the
widen-dependencies
branch
from
e7f6c82
to
3e62977
Compare
This should make it easier to install Feast alongside other Python packages. Signed-off-by: Abhin Chhabra <chhabra.abhin@gmail.com> Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
Signed-off-by: Abhin Chhabra <chhabra.abhin@gmail.com> Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
Signed-off-by: Abhin Chhabra <chhabra.abhin@gmail.com> Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
This was covered in feast-dev#2537. I've only generated lockfiles for Python 3.8 to test this in CI. I'll do the same for the rest of the Python versions later. Signed-off-by: Abhin Chhabra <abhin.chhabra@shopify.com> Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
kevjumba
force-pushed
the
widen-dependencies
branch
from
526074f
to
3ac271e
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, chhabrakadabra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Widening the dependency ranges will allow Feast to be easily installable alongside other packages. Incidentally, the dependencies are widened upwards (the upper-bound on the ranges is increased), which will lead to lots of library upgrades. I might split this into multiple PRs if the upgrades cause too much chaos in CI.
Which issue(s) this PR fixes:
Fixes #2906
Additional notes
blackbecause the older version of black interacted poorly with the latest version of click (see this for more details).sdk/python/feast/embedded_go/libdirectory has been excluded fromblack. The same thing had already been done for isort, flake8 and mypy, but not for black. It makes sense to exclude autogenerated code from linting and the newest version of black was trying to reformat autogenerated/non-committed code and failing.