Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch ingestion fix #299

Merged
merged 1 commit into from
Nov 10, 2019
Merged

Conversation

zhilingc
Copy link
Collaborator

Originally in PR #288, but moving it out because that might take awhile more to fix.

This PR

  • Adds missing argument to _serving_service_stub.GetFeastServingInfo
  • Fixes lookups to featuresets with different entities not returning anything

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: woop, zhilingc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member

woop commented Nov 10, 2019

/lgtm

@feast-ci-bot feast-ci-bot merged commit 43a69da into feast-dev:0.3-dev Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants