Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add default ttl for feature views #3037

Merged
merged 2 commits into from Aug 9, 2022

Conversation

felixwang9817
Copy link
Collaborator

Signed-off-by: Felix Wang wangfelix98@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2022

Codecov Report

Merging #3037 (c3c3c47) into master (1996596) will decrease coverage by 9.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3037      +/-   ##
==========================================
- Coverage   67.66%   58.61%   -9.06%     
==========================================
  Files         167      198      +31     
  Lines       14691    16344    +1653     
==========================================
- Hits         9941     9580     -361     
- Misses       4750     6764    +2014     
Flag Coverage Δ
integrationtests ?
unittests 58.61% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/feature_view.py 92.66% <ø> (-4.00%) ⬇️
sdk/python/feast/stream_feature_view.py 90.35% <ø> (+14.03%) ⬆️
...fline_store/test_universal_historical_retrieval.py 28.75% <ø> (-71.25%) ⬇️
sdk/python/tests/unit/diff/test_registry_diff.py 100.00% <ø> (+83.78%) ⬆️
...sts/integration/registration/test_universal_cli.py 20.20% <0.00%> (-79.80%) ⬇️
...ts/integration/offline_store/test_offline_write.py 26.08% <0.00%> (-73.92%) ⬇️
...ests/integration/e2e/test_python_feature_server.py 29.50% <0.00%> (-70.50%) ⬇️
...dk/python/tests/integration/e2e/test_validation.py 27.55% <0.00%> (-69.30%) ⬇️
...s/integration/registration/test_universal_types.py 32.25% <0.00%> (-67.75%) ⬇️
... and 154 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [achals,adchia,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@feast-ci-bot feast-ci-bot removed the lgtm label Aug 9, 2022
@kevjumba
Copy link
Collaborator

kevjumba commented Aug 9, 2022

/lgtm

@feast-ci-bot feast-ci-bot merged commit af5123f into feast-dev:master Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants