Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Make java build only work on feast-dev/feast because it uses Feast secrets #3054

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

adchia
Copy link
Collaborator

@adchia adchia commented Aug 9, 2022

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

… Feast secrets

Signed-off-by: Danny Chiao <danny@tecton.ai>
Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adchia,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 32d2039 into feast-dev:master Aug 10, 2022
adchia added a commit that referenced this pull request Aug 10, 2022
…t secrets (#3054)

ci: Make java build only work on feast-dev/feast because it relies on Feast secrets

Signed-off-by: Danny Chiao <danny@tecton.ai>
@adchia adchia deleted the fixBuild branch May 9, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants