Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix release workflow to release 0.24.0 #3138

Merged
merged 6 commits into from
Aug 25, 2022
Merged

fix: Fix release workflow to release 0.24.0 #3138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
504b5cb
Fix
kevjumba Aug 24, 2022
32d40f1
fix
kevjumba Aug 24, 2022
9bfe931
temporary fix
kevjumba Aug 25, 2022
dca542e
Fix
kevjumba Aug 25, 2022
13f8364
Fix
kevjumba Aug 25, 2022
37396b7
Fix
kevjumba Aug 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/build_wheels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ jobs:
make install-go-ci-dependencies
git status
git restore go.mod go.sum
git restore sdk/python/feast/ui/yarn.lock
CIBW_BEFORE_TEST: "cd {project} && git status"
# py3.10 on MacOS does not work with Go so we have to install separately. Issue is tracked here: https://github.com/feast-dev/feast/issues/2881.
- name: Build py310 specific wheels for macos
Expand All @@ -104,6 +105,7 @@ jobs:
CIBW_BEFORE_BUILD: |
git status
git restore go.mod go.sum
git restore sdk/python/feast/ui/yarn.lock
brew install apache-arrow
- uses: actions/upload-artifact@v2
with:
Expand Down Expand Up @@ -136,6 +138,7 @@ jobs:
make build-ui
git status
git restore go.mod go.sum
git restore sdk/python/feast/ui/yarn.lock
- name: Build
run: |
python3 setup.py sdist
Expand Down Expand Up @@ -232,7 +235,7 @@ jobs:
- name: Smoke test
run: |
feast init test_repo
cd test_repo/
cd test_repo/feature_repo
feast apply
echo "$TEST_SCRIPT" > run-and-wait.sh
bash run-and-wait.sh feast serve
Expand All @@ -241,7 +244,7 @@ jobs:
- name: Smoke test with go
if: matrix.python-version != '3.10' || matrix.os == 'ubuntu-latest'
run: |
cd test_repo/
cd test_repo/feature_repo
feast apply
echo "$TEST_SCRIPT" > run-and-wait.sh
pip install cffi
Expand Down
60 changes: 30 additions & 30 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,40 +42,40 @@ jobs:
echo "Current version is ${CURRENT_VERSION}"
echo "Next version is ${NEXT_VERSION}"

publish-web-ui-npm:
if: github.repository == 'feast-dev/feast'
needs: get_dry_release_versions
runs-on: ubuntu-latest
env:
# This publish is working using an NPM automation token to bypass 2FA
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
CURRENT_VERSION: ${{ needs.get_dry_release_versions.outputs.current_version }}
NEXT_VERSION: ${{ needs.get_dry_release_versions.outputs.next_version }}
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
with:
node-version: '17.x'
registry-url: 'https://registry.npmjs.org'
- name: Bump file versions (temporarily for Web UI publish)
run: python ./infra/scripts/release/bump_file_versions.py ${CURRENT_VERSION} ${NEXT_VERSION}
- name: Install yarn dependencies
working-directory: ./ui
run: yarn install
- name: Build yarn rollup
working-directory: ./ui
run: yarn build:lib
- name: Publish UI package
working-directory: ./ui
run: npm publish
env:
# This publish is working using an NPM automation token to bypass 2FA
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
# publish-web-ui-npm:
# if: github.repository == 'feast-dev/feast'
# needs: get_dry_release_versions
# runs-on: ubuntu-latest
# env:
# # This publish is working using an NPM automation token to bypass 2FA
# NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
# CURRENT_VERSION: ${{ needs.get_dry_release_versions.outputs.current_version }}
# NEXT_VERSION: ${{ needs.get_dry_release_versions.outputs.next_version }}
# steps:
# - uses: actions/checkout@v2
# - uses: actions/setup-node@v2
# with:
# node-version: '17.x'
# registry-url: 'https://registry.npmjs.org'
# - name: Bump file versions (temporarily for Web UI publish)
# run: python ./infra/scripts/release/bump_file_versions.py ${CURRENT_VERSION} ${NEXT_VERSION}
# - name: Install yarn dependencies
# working-directory: ./ui
# run: yarn install
# - name: Build yarn rollup
# working-directory: ./ui
# run: yarn build:lib
# - name: Publish UI package
# working-directory: ./ui
# run: npm publish
# env:
# # This publish is working using an NPM automation token to bypass 2FA
# NPM_TOKEN: ${{ secrets.NPM_TOKEN }}

release:
name: release
runs-on: ubuntu-latest
needs: publish-web-ui-npm
#needs: publish-web-ui-npm
env:
GITHUB_TOKEN: ${{ github.event.inputs.token }}
GIT_AUTHOR_NAME: feast-ci-bot
Expand Down